Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communication: Allow tutors to monitor channels as moderator #9874

Merged

Conversation

cremertim
Copy link
Contributor

@cremertim cremertim commented Nov 26, 2024

Checklist

General

Server

Client

  • I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
  • I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

Currently, tutors are not able to monitor chats without the cumbersome work of granting each tutor for each channel moderation rights. This affects teaching, since instructors cannot monitor every channel on their own with potentially over 2000 students asking questions

Description

I allowed tutors to pin, delete post and answer posts, if they are not an announcement.

Steps for Testing

Prerequisites:

  • 1 Tutor
  • 1 Instructor
  1. Log in to Artemis
  2. Navigate to Course Overview
  3. Try to delete an post and an answer to this post from a different user as tutor and instructor (should be possible)
  4. Try to delete an announcement as tutor (should not be possible) and as instructor (should be possible)

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Test Coverage

Screenshots

image

Summary by CodeRabbit

Release Notes

  • New Features

    • Enhanced user role management for moderators in course-wide channels based on channel type (announcement vs. regular).
    • Updated permissions for deleting posts, allowing tutors to delete answers in course-wide channels.
  • Bug Fixes

    • Corrected visibility of edit and delete options for tutors and instructors based on user roles and post types.
  • Tests

    • Updated test cases to reflect new logic for user permissions regarding post editing and deletion.
    • Added assertions to ensure correct behavior of UI elements based on user roles.

@github-actions github-actions bot added server Pull requests that update Java code. (Added Automatically!) client Pull requests that update TypeScript code. (Added Automatically!) communication Pull requests that affect the corresponding module labels Nov 26, 2024
@cremertim cremertim closed this Nov 26, 2024
…erate-channel

# Conflicts:
#	src/main/webapp/app/shared/metis/posting-reactions-bar/answer-post-reactions-bar/answer-post-reactions-bar.component.ts
#	src/main/webapp/app/shared/metis/posting-reactions-bar/post-reactions-bar/post-reactions-bar.component.ts
@cremertim cremertim reopened this Nov 26, 2024
@github-actions github-actions bot added the tests label Nov 27, 2024
Copy link
Contributor

@asliayk asliayk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on ts2, everything worked as described

Copy link

@eylulnc eylulnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in TS2

Copy link
Member

@anian03 anian03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested during Testing session on TS2, works as expected

Copy link
Contributor

@PaRangger PaRangger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, Tested on TS2.

Copy link

@HawKhiem HawKhiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS2. I can indeed delete messages of other users as instuctor but not as tutor

Screenshot 2024-12-02 223846
Screenshot 2024-12-02 223932

Copy link
Contributor

@julian-wls julian-wls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS2, works as expected!

@cremertim cremertim added this to the 7.7.5 milestone Dec 4, 2024
Copy link
Contributor

@SimonEntholzer SimonEntholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code

Copy link

@ahbitaqu ahbitaqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Tested on TS2]
Behaves exactly as desribed in the new description :)

@krusche krusche merged commit 553e9c1 into develop Dec 5, 2024
42 of 46 checks passed
@krusche krusche deleted the feature/communication/allow-tutors-to-moderate-channel branch December 5, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) communication Pull requests that affect the corresponding module feature ready for review ready to merge server Pull requests that update Java code. (Added Automatically!) tests
Projects
Archived in project
Status: Done
Development

Successfully merging this pull request may close these issues.