Communication: Fix padding issues in channel search and post components

[PaRangger]

Checklist

General

• I tested all changes and their related features with all corresponding user types on a test server.
• This is a small issue that I tested locally and was confirmed by another developer on a test server.
• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Client

• I strictly followed the client coding and design guidelines.
• Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
• I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

Currently, there are some padding issues when searching for announcement posts. This makes the search result look buggy:

This was accompanied by another issue that consecutive announcements that were saved did not color the title accordingly:

Lastly, also the channel internal search had some missing padding, making it look out-of-line with the other components:

Description

I added some padding to the search component and removed the padding at the announcement channel title and added the coloring to the background if saved.

Steps for Testing

Prerequisites:

• 1 User
• 1 Course with communication enabled

1. Log into Artemis
2. Go to course
3. Go to the communication tab
4. Open a channel
5. Click on the channel-search button
6. Check if the search input is aligned with the other components
7. Search for a keyword within a announcement
8. Check if the channel title in the result is aligned with the message

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Screenshots

Announcement Title:

Search input:

Summary by CodeRabbit

• New Features

  • Enhanced layout for the conversation messages and post components, improving user experience.
  • Introduced a new class for styling context information in posts.

• Bug Fixes

  • Adjusted padding and layout for the search bar section to ensure better visibility and usability.

• Documentation

  • Improved HTML structure for better readability and maintainability without altering functionality.

[coderabbitai]

Walkthrough

The pull request includes modifications to the HTML structure and styling of the conversation-messages.component.html and post.component.html files, focusing on layout adjustments and class bindings. The changes enhance the visual presentation of the components without altering their underlying logic or functionality. New class definitions were introduced in the corresponding SCSS file to support these adjustments, ensuring improved readability and maintainability of the code.

Changes

File Path	Change Summary
src/main/webapp/app/overview/course-conversations/layout/conversation-messages/conversation-messages.component.html	Modified HTML structure and class attributes for layout adjustments in the conversation messages component.
src/main/webapp/app/shared/metis/post/post.component.html	Adjusted HTML structure and class bindings to improve styling and readability in the post component.
src/main/webapp/app/shared/metis/post/post.component.scss	Introduced a new class .post-context-information-wrap to the styles without altering existing properties.

Possibly related PRs

• Communication: Enhance messages and threads user interface #8706: The changes in the main PR regarding the layout adjustments in conversation-messages.component.html relate to the enhancements made in the post.component.html, as both involve modifications to the HTML structure and class bindings that affect the user interface of message components.
• Communication: Fix an issue where the client does not keep track of the posts on screen #8990: The updates in the main PR to the conditions for displaying elements in conversation-messages.component.html are closely related to the changes made in course-wide-search.component.html, where similar logic for displaying messages based on the presence of posts was modified.
• Development: Fix duplicate server calls for messages when selecting a conversation #9611: The optimization of the ConversationMessagesComponent in the main PR to prevent duplicate API calls when selecting a conversation aligns with the changes made in the same component regarding the handling of active conversations, enhancing overall efficiency.
• Communication: Fix element height in announcement channel #9664: The modifications in the main PR to improve the visibility of input fields in conversation-messages.component.html are related to the changes made to the same file, which enhance the conditional rendering of CSS classes based on the conversation type.
• Communication: Fix an issue that stops channels from loading messages #9745: The fix in the main PR for loading messages in communication channels directly addresses the issue of handling deleted users, which is relevant to the changes made in the PostingHeaderDirective that ensure the UI can still display relevant information even when author roles are unrecognized.
• Communication: Add unread message notification icon to sidebar accordion #9737: The addition of unread message notifications in the sidebar accordion in the main PR complements the layout adjustments in conversation-messages.component.html, as both aim to enhance user awareness of unread messages within the communication interface.

Suggested labels

user interface, ready to merge

Suggested reviewers

• florian-glombik
• JohannesStoehr
• rabeatwork
• az108
• krusche
• HawKhiem

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between dece904 and 8c50f3a.

📒 Files selected for processing (3)

• src/main/webapp/app/overview/course-conversations/layout/conversation-messages/conversation-messages.component.html (1 hunks)
• src/main/webapp/app/shared/metis/post/post.component.html (2 hunks)
• src/main/webapp/app/shared/metis/post/post.component.scss (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• src/main/webapp/app/shared/metis/post/post.component.scss

🧰 Additional context used

📓 Path-based instructions (2)

src/main/webapp/app/shared/metis/post/post.component.html (1)

Pattern src/main/webapp/**/*.html: @if and @for are new and valid Angular syntax replacing *ngIf and *ngFor. They should always be used over the old style.

src/main/webapp/app/overview/course-conversations/layout/conversation-messages/conversation-messages.component.html (1)

Pattern src/main/webapp/**/*.html: @if and @for are new and valid Angular syntax replacing *ngIf and *ngFor. They should always be used over the old style.

🔇 Additional comments (5)

src/main/webapp/app/overview/course-conversations/layout/conversation-messages/conversation-messages.component.html (1)

4-4: LGTM! Padding adjustment improves layout consistency

The change from p-0 to px-3 py-0 adds horizontal padding while maintaining zero vertical padding, which aligns with the PR's objective to fix padding issues in the search component.

src/main/webapp/app/shared/metis/post/post.component.html (4)

24-25: LGTM! Improved structure with dedicated wrapper class

The introduction of post-context-information-wrap class provides better organization and maintainability for styling post context information.

---

30-30: LGTM! Refined announcement icon spacing

The padding adjustment pe-0 ms-1 ensures consistent spacing around the announcement icon.

---

37-40: LGTM! Consistent margin application

The margin classes (ms-1) are consistently applied across different context information elements, maintaining uniform spacing.

Also applies to: 49-49

---

55-57: LGTM! Simplified post title structure

The span structure for post titles has been simplified while maintaining proper spacing with ms-1.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[ahbitaqu]

[Tested on TS2]
Works as described for me!

Search padding is there

Announcement is aligned as well:

[asliayk]

tested locally, works as described

[HawKhiem]

Tested on TS2. Works as described

[Haoyuli2002]

Tested on TS2, I could successfully see that the channel title in the result is aligned with the message. This feature couuld really help students to better navigate through different messages to the correct chanel and I think this feature is working well :D.

[SimonKaran13]

I tested on TS2 and it works as expected. The channel name and the icon are correctly aligned with the message. I also tried resizing the window and it worked fine as well.