DM-47395: Improve type annotation for DefineVisitTask.run #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfisherlevine
force-pushed
the
tickets/DM-47395
branch
from
b3b93e7 to
43d585a
Compare
mfisherlevine
force-pushed
the
tickets/DM-47395
branch
from
43d585a to
0d5b9fa
Compare
timj
reviewed
Nov 5, 2024
| @@ -635,7 +635,7 @@ def run( | |||
| dataIds : `Iterable` [ `dict` or `~lsst.daf.butler.DataCoordinate` ] | |||
| Exposure-level data IDs. These must all correspond to the same | |||
| instrument, and are expected to be on-sky science exposures. | |||
| collections : Any, optional | |||
| collections : `Sequence` [ `str` ] or `str` or `None` | |||
There was a problem hiding this comment.
Do you also need to change the typing for _buildVisitRecords which uses Any at the moment? And compute visit regions compute method?
There was a problem hiding this comment.
I was trying to quickly fix the mypy error I'm getting. I take your point, but I'm worried that's going to snowball. I'll give it a quick try though...
There was a problem hiding this comment.
OK, I've pushed that and am running local tests & mypy 🤞
There was a problem hiding this comment.
OK, seems to have gone well - Jenkins running...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes