-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version output to CLI #1352
base: master
Are you sure you want to change the base?
Conversation
@@ -1,6 +1,8 @@ | |||
// This file is part of the Luau programming language and is licensed under MIT License; see LICENSE.txt for details | |||
#pragma once | |||
|
|||
#define LUAU_VERSION "Luau 0.636" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love the idea of just having a hardcoded version string like this, particularly because it means that we'll have to manually update this string every time.
I think the "right" way to do this might be something like... resolving the version by finding the most recent git release tag at build-time, which is kind of awful in-and-of-itself. Similarly, it would be nice to include the slug for the git hash in the release string as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @andyfriesen do you have some thoughts on a good way to do this beyond hard-coding the version string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If only there was a tool that we ran each time we sync code that we could modify to handle this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has to be automated, updating manually on each release is not an option.
Closes #1342.