Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid circular imports #334

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

cjwatson
Copy link

https://bugs.debian.org/1069838 reported a test failure due to circular imports. While I couldn't reproduce this locally, I could reproduce it in a VM provided by the bug reporter, and it seems straightforward enough to avoid the problem.

https://bugs.debian.org/1069838 reported a test failure due to circular
imports.  While I couldn't reproduce this locally, I could reproduce it
in a VM provided by the bug reporter, and it seems straightforward
enough to avoid the problem.
@lucc
Copy link
Owner

lucc commented Jun 27, 2024

I am happy with the conditional typing import but the local import bothers me. I was under the impression that it is good python coding style to put all imports at the top. This breaks it.

I understand that we need to do a real import of the carddav_object module at some point because we really use it. But the motivation is not obvious if I read the code in isolation and any future developer who does not have your specific VM will not notice any problem if they change it again.

So the main question is: Is there really no way to reproduce this problem outside of your VM? Is there some environment that we can specify declarative to reproduce this?

@lucc lucc added question waiting Waiting for more information labels Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question waiting Waiting for more information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants