Fix param examples incorrectly made into arrays #1465
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1464
All Submissions:
Potential Problems With The Approach
It would be better to allow for multiple examples in methods having
@BodyProp
parameters, but the current solution to toss multiple examples into an array does not work as expected (it assumes that the example value of the prop is the array itself).Multiple examples need to be addressed at the schema level rather than the prop level. This exceeds the scope of this bugfix.
Test plan
@BodyProp
. In both cases it is expected that examples after the first are ignored.