Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support response using inner interface #1724

Merged
merged 3 commits into from
Dec 8, 2024

Conversation

mdoi2
Copy link
Contributor

@mdoi2 mdoi2 commented Nov 29, 2024

Fixed bug #1723 and #1629.
This feature worked as v5, but errors began to occur from v6.
If this commit is incomplete, please point it out to me.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

Closing issues

closes #1723

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there mdoi2 👋

Thank you and congrats 🎉 for opening your first PR on this project.✨

We will review the following PR soon! 👀

@WoH WoH force-pushed the master branch 2 times, most recently from 30cc104 to 82b61ec Compare December 8, 2024 16:44
@WoH
Copy link
Collaborator

WoH commented Dec 8, 2024

Happy to try it, it looks reasonable, but if you have a ELI5 comment for me that'd be great.

@WoH WoH merged commit ca2068d into lukeautry:master Dec 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: This node kind is unknown: 241 from v6
2 participants