fix: failing tests for lsp23 + add LSP23 test suite in CI (#657)

* tests: fix lsp23 tests * ci: add lsp23 tests to lint workflow
lukso-network · Aug 7, 2023 · 0e5d9bf · 0e5d9bf
1 parent e26f9d5
commit 0e5d9bf
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/.github/workflows/build-lint-test.yml b/.github/workflows/build-lint-test.yml
@@ -66,6 +66,7 @@ jobs:
             "lsp11init",
             "lsp20",
             "lsp20init",
+            "lsp23",
             "universalfactory",
             "reentrancy",
             "reentrancyinit",

diff --git a/package.json b/package.json
@@ -64,6 +64,7 @@
     "test:lsp11init": "hardhat test --no-compile tests/LSP11BasicSocialRecovery/LSP11BasicSocialRecoveryInit.test.ts",
     "test:lsp20": "hardhat test --no-compile tests/LSP20CallVerification/LSP6/LSP20WithLSP6.test.ts",
     "test:lsp20init": "hardhat test --no-compile tests/LSP20CallVerification/LSP6/LSP20WithLSP6Init.test.ts",
+    "test:lsp23": "hardhat test --no-compile tests/LSP23MultiChainDeployment/LSP23MultiChainDeployment.test.ts",
     "test:universalfactory": "hardhat test --no-compile tests/LSP16UniversalFactory/LSP16UniversalFactory.test.ts",
     "test:reentrancy": "hardhat test --no-compile tests/Reentrancy/Reentrancy.test.ts",
     "test:reentrancyinit": "hardhat test --no-compile tests/Reentrancy/ReentrancyInit.test.ts",

diff --git a/...nt/LSP23MultiChainDeployment.behaviour.ts → ...loyment/LSP23MultiChainDeployment.test.ts b/...nt/LSP23MultiChainDeployment.behaviour.ts → ...loyment/LSP23MultiChainDeployment.test.ts
@@ -31,15 +31,15 @@ describe('UniversalProfileDeployer', function () {
     const ownerControlledDeploymentInit: OwnerControlledContractDeployer.ControlledContractDeploymentInitStruct =
       {
         salt,
-        value: 0,
+        fundingAmount: 0,
         implementationContract: universalProfileInit.address,
         initializationCalldata: universalProfileInit.interface.encodeFunctionData('initialize', [
           upPostDeploymentModule.address,
         ]),
       };
 
     const ownerDeploymentInit: OwnerControlledContractDeployer.OwnerContractDeploymentInitStruct = {
-      value: 0,
+      fundingAmount: 0,
       implementationContract: keyManagerInit.address,
       addControlledContractAddress: true,
       initializationCalldata: '0xc4d66de8',
@@ -113,12 +113,8 @@ describe('UniversalProfileDeployer', function () {
 
     const [expectedUpProxyAddress, expectedKeyManagerProxyAddress] =
       await ownerControlledContractDeployer.computeERC1167Addresses(
-        ownerControlledDeploymentInit.salt,
-        ownerControlledDeploymentInit.implementationContract,
-        ownerDeploymentInit.implementationContract,
-        ownerDeploymentInit.initializationCalldata,
-        ownerDeploymentInit.addControlledContractAddress,
-        ownerDeploymentInit.extraInitializationParams,
+        ownerControlledDeploymentInit,
+        ownerDeploymentInit,
         upPostDeploymentModule.address,
         encodedBytes,
       );