Skip to content

Commit

Permalink
test: fix more failing ethers v6 types and functions
Browse files Browse the repository at this point in the history
  • Loading branch information
CJ42 committed Feb 18, 2024
1 parent 83c1db1 commit 50c34b6
Show file tree
Hide file tree
Showing 9 changed files with 84 additions and 1,173 deletions.
9 changes: 9 additions & 0 deletions packages/lsp16-contracts/contracts/Mock/FallbackContract.sol
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// SPDX-License-Identifier: Apache-2.0
pragma solidity ^0.8.4;

/**
* @dev sample contract used for testing
*/
contract FallbackContract {
fallback() external payable {}
}
9 changes: 5 additions & 4 deletions packages/lsp16-contracts/tests/LSP16UniversalFactory.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import {
FallbackInitializer__factory,
ContractNoConstructor__factory,
ContractNoConstructor,
FallbackContract__factory,
} from '../types';

import type { SignerWithAddress } from '@nomicfoundation/hardhat-ethers/signers';
Expand Down Expand Up @@ -108,7 +109,7 @@ describe('UniversalFactory contract', () => {
bytecodeHash,
salt,
false,
[],
[] as unknown as Uint8Array,
);

const contractCreated = await context.universalFactory
Expand Down Expand Up @@ -462,15 +463,15 @@ describe('UniversalFactory contract', () => {
await context.universalFactory.deployCreate2AndInitialize.staticCall(
fallbackInitializerBytecode,
salt,
[], // empty initializeCallData
[] as unknown as Uint8Array, // empty initializeCallData
0,
0,
);

await context.universalFactory.deployCreate2AndInitialize(
fallbackInitializerBytecode,
salt,
[], // empty initializeCallData
[] as unknown as Uint8Array, // empty initializeCallData
0,
0,
);
Expand Down Expand Up @@ -905,7 +906,7 @@ describe('UniversalFactory contract', () => {
await expect(
context.universalFactory
.connect(context.accounts.deployer1)
.deployERC1167ProxyAndInitialize(fallbackContract.address, salt, RandomCalldata),
.deployERC1167ProxyAndInitialize(fallbackContract.target, salt, RandomCalldata),
).to.not.be.reverted;
});

Expand Down
Loading

0 comments on commit 50c34b6

Please sign in to comment.