-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: (C4 #139) refactor _fallbackLSP17Extendable
function to enable to run code after it is called + prevent potential solc bug "storage write removal"
#674
fix: (C4 #139) refactor _fallbackLSP17Extendable
function to enable to run code after it is called + prevent potential solc bug "storage write removal"
#674
Conversation
👋 Hello ⛽📊 See Gas Benchmark report of Using UniversalProfile owned by an EOA🔀
|
execute scenarios - 👑 UP Owner |
⛽ Gas Usage |
---|---|
Transfer 1 LYX to an EOA without data | 37537 |
Transfer 1 LYX to a UP without data | 36639 |
Transfer 1 LYX to an EOA with 256 bytes of data | 42210 |
Transfer 1 LYX to a UP with 256 bytes of data | 44831 |
Transfer 0.1 LYX to 3x EOA without data | 70862 |
Transfer 0.1 LYX to 3x UP without data | 75680 |
Transfer 0.1 LYX to 3x EOA with 256 bytes of data | 84826 |
Transfer 0.1 LYX to 3x EOA with 256 bytes of data | 100321 |
🗄️ setData
scenarios
setData scenarios - 👑 UP Owner |
⛽ Gas Usage |
---|---|
Set a 20 bytes long value | 49971 |
Set a 60 bytes long value | 95281 |
Set a 160 bytes long value | 164453 |
Set a 300 bytes long value | 279688 |
Set a 600 bytes long value | 484136 |
Change the value of a data key already set | 32847 |
Remove the value of a data key already set | 27333 |
Set 2 data keys of 20 bytes long value | 78428 |
Set 2 data keys of 100 bytes long value | 260568 |
Set 3 data keys of 20 bytes long value | 105145 |
Change the value of three data keys already set of 20 bytes long value | 45445 |
Remove the value of three data keys already set | 41339 |
🗄️ Tokens
scenarios
Tokens scenarios - 👑 UP Owner |
⛽ Gas Usage |
---|---|
Minting a LSP7Token to a UP (No Delegate) from an EOA | 91241 |
Minting a LSP7Token to an EOA from an EOA | 59206 |
Transferring an LSP7Token from a UP to another UP (No Delegate) | 98689 |
Minting a LSP8Token to a UP (No Delegate) from an EOA | 158192 |
Minting a LSP8Token to an EOA from an EOA | 126157 |
Transferring an LSP8Token from a UP to another UP (No Delegate) | 147236 |
📝 Notes
- The
execute
andsetData
scenarios are executed on a fresh UniversalProfile smart contract, deployed as standard contracts (not as proxy behind a base contract implementation).
⛽📊 See Gas Benchmark report of Using UniversalProfile owned by an LSP6KeyManager
This document contains the gas usage for common interactions and scenarios when using UniversalProfile smart contracts.
🔀 execute
scenarios
👑 unrestricted controller
execute scenarios - 👑 main controller |
⛽ Gas Usage |
---|---|
transfer LYX to an EOA | 60445 |
transfer LYX to a UP | 62047 |
transfer tokens (LSP7) to an EOA (no data) | 107168 |
transfer tokens (LSP7) to a UP (no data) | 242740 |
transfer a NFT (LSP8) to a EOA (no data) | 171015 |
transfer a NFT (LSP8) to a UP (no data) | 289915 |
🛃 restricted controller
execute scenarios - 🛃 restricted controller |
⛽ Gas Usage |
---|---|
transfer some LYXes to an EOA - restricted to 1 x allowed address only (TRANSFERVALUE + 1x AllowedCalls) | 72654 |
transfers some tokens (LSP7) to an EOA - restricted to LSP7 + 2x allowed contracts only (CALL + 2x AllowedCalls) (no data) | 122947 |
transfers some tokens (LSP7) to an other UP - restricted to LSP7 + 2x allowed contracts only (CALL + 2x AllowedCalls) (no data) | 258519 |
transfers a NFT (LSP8) to an EOA - restricted to LSP8 + 2x allowed contracts only (CALL + 2x AllowedCalls) (no data) | 186782 |
transfers a NFT (LSP8) to an other UP - restricted to LSP8 + 2x allowed contracts only (CALL + 2x AllowedCalls) (no data) | 305682 |
🗄️ setData
scenarios
👑 unrestricted controller
setData scenarios - 👑 main controller |
⛽ Gas Usage |
---|---|
updates profile details (LSP3Profile metadata) | 136875 |
give permissions to a controller (AddressPermissions[] + AddressPermissions[index] + AddressPermissions:Permissions:) | 132906 |
restrict a controller to some specific ERC725Y Data Keys | 139282 |
restrict a controller to interact only with 3x specific addresses | 161986 |
remove a controller (its permissions + its address from the AddressPermissions[] array) | 67871 |
write 5x LSP12 Issued Assets | 233253 |
🛃 restricted controller
setData scenarios - 🛃 restricted controller |
⛽ Gas Usage |
---|---|
setData(bytes32,bytes) -> updates 1x data key |
102626 |
setData(bytes32[],bytes[]) -> updates 3x data keys (first x3) |
161440 |
setData(bytes32[],bytes[]) -> updates 3x data keys (middle x3) |
145519 |
setData(bytes32[],bytes[]) -> updates 3x data keys (last x3) |
170752 |
setData(bytes32[],bytes[]) -> updates 2x data keys + add 3x new controllers (including setting the array length + indexes under AddressPermissions[index]) |
249872 |
📝 Notes
- The
execute
andsetData
scenarios are executed on a fresh UniversalProfile and LSP6KeyManager smart contracts, deployed as standard contracts (not as proxy behind a base contract implementation).
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
ce2136f
to
847428c
Compare
847428c
to
2614da8
Compare
2614da8
to
bf16c54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty cool
What does this PR introduce?
🐛 Bug
Currently, the function in LSP17
_fallbackLSP17Extendable
does not allow to run any code logic after this function is called, because it uses the low level opcodereturn()
in assembly.This restrict some potential customization through inheritance, when one want to run some custom code logic after this function is being called.
This PR refactor this function:
fallback
syntax:To the new following
fallback
syntax (available in all0.8.x
versions of Solidity).By removing assembly, , the function can be overriden to be called via
super._fallbackLSP17Extendable(...)
and run any code after.🧪 Tests
Created new test suite
LSP17Extendable.test.ts
to test the basic functionalities of LSP17 and this new refactoring.Tests include checking that storage write works as expected both before and after the
_fallbackLSP17Extension()
function is called.Also added tests to ensure different type of revert reason strings are bubble up.
PR Checklist
npm run lint
&&npm run lint:solidity
(solhint)npm run format
(prettier)npm run build
npm run test