Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add first implementation of LSP25 Execute Relay Call + update LSP6 interface ID #678
feat!: add first implementation of LSP25 Execute Relay Call + update LSP6 interface ID #678
Changes from all commits
c1e1587
083a31d
fae3147
a742a7f
abe3db7
b581c8b
9e9dcff
f12617e
baa731b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spoke to @YamenMerhi earlier about that but I believe it would make more sense that we consider
uint128(0)
to be theundefined
value.Meaning if I do not want to mention a
startingTimestamp
or aendingTimestamp
we should just leave this value empty.because right now if we want both to be empty we just leave them both empty (which makes sense) and it will return on line
107
however if I only want to have a
startingDate
I will need to give a value to theendingDate
. A "random" value orbytes(f)
but why?For UX reasons I think I would delibarately leave the values are initialized. More logic. Specially with our logic on line 107.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree here, such value for a
validityTimestamp
should work: