feat: allow sending value when using setData(..) through the LSP6
#725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hello ⛽📊 See Gas Benchmark report of Using UniversalProfile owned by an EOA🔀
|
execute scenarios - 👑 UP Owner |
⛽ Gas Usage |
|---|---|
| Transfer 1 LYX to an EOA without data | 37537 |
| Transfer 1 LYX to a UP without data | 36639 |
| Transfer 1 LYX to an EOA with 256 bytes of data | 42210 |
| Transfer 1 LYX to a UP with 256 bytes of data | 44855 |
| Transfer 0.1 LYX to 3x EOA without data | 70862 |
| Transfer 0.1 LYX to 3x UP without data | 75680 |
| Transfer 0.1 LYX to 3x EOA with 256 bytes of data | 84850 |
| Transfer 0.1 LYX to 3x EOA with 256 bytes of data | 100321 |
🗄️ setData scenarios
setData scenarios - 👑 UP Owner |
⛽ Gas Usage |
|---|---|
| Set a 20 bytes long value | 49971 |
| Set a 60 bytes long value | 95293 |
| Set a 160 bytes long value | 164465 |
| Set a 300 bytes long value | 279688 |
| Set a 600 bytes long value | 484148 |
| Change the value of a data key already set | 32859 |
| Remove the value of a data key already set | 27333 |
| Set 2 data keys of 20 bytes long value | 78428 |
| Set 2 data keys of 100 bytes long value | 260580 |
| Set 3 data keys of 20 bytes long value | 105145 |
| Change the value of three data keys already set of 20 bytes long value | 45445 |
| Remove the value of three data keys already set | 41339 |
🗄️ Tokens scenarios
Tokens scenarios - 👑 UP Owner |
⛽ Gas Usage |
|---|---|
| Minting a LSP7Token to a UP (No Delegate) from an EOA | 92016 |
| Minting a LSP7Token to an EOA from an EOA | 59323 |
| Transferring an LSP7Token from a UP to another UP (No Delegate) | 100102 |
| Minting a LSP8Token to a UP (No Delegate) from an EOA | 158946 |
| Minting a LSP8Token to an EOA from an EOA | 126253 |
| Transferring an LSP8Token from a UP to another UP (No Delegate) | 148671 |
📝 Notes
- The
executeandsetDatascenarios are executed on a fresh UniversalProfile smart contract, deployed as standard contracts (not as proxy behind a base contract implementation).
⛽📊 See Gas Benchmark report of Using UniversalProfile owned by an LSP6KeyManager
This document contains the gas usage for common interactions and scenarios when using UniversalProfile smart contracts.
🔀 execute scenarios
👑 unrestricted controller
execute scenarios - 👑 main controller |
⛽ Gas Usage |
|---|---|
| transfer LYX to an EOA | 60466 |
| transfer LYX to a UP | 62068 |
| transfer tokens (LSP7) to an EOA (no data) | 107986 |
| transfer tokens (LSP7) to a UP (no data) | 244403 |
| transfer a NFT (LSP8) to a EOA (no data) | 171855 |
| transfer a NFT (LSP8) to a UP (no data) | 291519 |
🛃 restricted controller
execute scenarios - 🛃 restricted controller |
⛽ Gas Usage |
|---|---|
| transfer some LYXes to an EOA - restricted to 1 x allowed address only (TRANSFERVALUE + 1x AllowedCalls) | 71658 |
| transfers some tokens (LSP7) to an EOA - restricted to LSP7 + 2x allowed contracts only (CALL + 2x AllowedCalls) (no data) | 122677 |
| transfers some tokens (LSP7) to an other UP - restricted to LSP7 + 2x allowed contracts only (CALL + 2x AllowedCalls) (no data) | 259094 |
| transfers a NFT (LSP8) to an EOA - restricted to LSP8 + 2x allowed contracts only (CALL + 2x AllowedCalls) (no data) | 186511 |
| transfers a NFT (LSP8) to an other UP - restricted to LSP8 + 2x allowed contracts only (CALL + 2x AllowedCalls) (no data) | 306175 |
🗄️ setData scenarios
👑 unrestricted controller
setData scenarios - 👑 main controller |
⛽ Gas Usage |
|---|---|
| updates profile details (LSP3Profile metadata) | 136859 |
| give permissions to a controller (AddressPermissions[] + AddressPermissions[index] + AddressPermissions:Permissions:) | 132994 |
| restrict a controller to some specific ERC725Y Data Keys | 139266 |
| restrict a controller to interact only with 3x specific addresses | 161970 |
| remove a controller (its permissions + its address from the AddressPermissions[] array) | 67973 |
| write 5x LSP12 Issued Assets | 233237 |
🛃 restricted controller
setData scenarios - 🛃 restricted controller |
⛽ Gas Usage |
|---|---|
setData(bytes32,bytes) -> updates 1x data key |
102760 |
setData(bytes32[],bytes[]) -> updates 3x data keys (first x3) |
161499 |
setData(bytes32[],bytes[]) -> updates 3x data keys (middle x3) |
145653 |
setData(bytes32[],bytes[]) -> updates 3x data keys (last x3) |
170986 |
setData(bytes32[],bytes[]) -> updates 2x data keys + add 3x new controllers (including setting the array length + indexes under AddressPermissions[index]) |
250985 |
📝 Notes
- The
executeandsetDatascenarios are executed on a fresh UniversalProfile and LSP6KeyManager smart contracts, deployed as standard contracts (not as proxy behind a base contract implementation).
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
b00ste
force-pushed
the
feat/lsp6-setdata-payable
branch
from
c677b0e
to
90639e1
Compare
b00ste
force-pushed
the
feat/lsp6-setdata-payable
branch
3 times, most recently
from
dae3572
to
1d5a637
Compare
CJ42
approved these changes
Sep 22, 2023
b00ste
force-pushed
the
feat/lsp6-setdata-payable
branch
4 times, most recently
from
d265fd8
to
570367d
Compare
CJ42
requested changes
Sep 27, 2023
There was a problem hiding this comment.
If we allow to send native tokens while setting data, we need now to add the permission check of TRANSFERVALUE while setting data + tests for it.
Sorry my bad, I got confused 🫠
I suggest we park this PR on the side and put it as draft for now until we have discussed and agreed on the decision with @frozeman
| @@ -544,7 +546,6 @@ abstract contract LSP6KeyManagerCore is | |||
|
|
|||
| // ERC725Y.setData(bytes32,bytes) | |||
| if (erc725Function == IERC725Y.setData.selector) { | |||
| if (msgValue != 0) revert CannotSendValueToSetData(); | |||
There was a problem hiding this comment.
Since we are removing the custom error, we need to check for permission TRANSFERVALUE in addition to check for the permission SETDATA below via _verifyCanSetData(...).
There was a problem hiding this comment.
why? It is just founding the account when setting data? not transfering?
b00ste
force-pushed
the
feat/lsp6-setdata-payable
branch
from
570367d
to
04349db
Compare
b00ste
force-pushed
the
feat/lsp6-setdata-payable
branch
2 times, most recently
from
415a708
to
489b3ba
Compare
b00ste
force-pushed
the
feat/lsp6-setdata-payable
branch
from
489b3ba
to
944dad2
Compare
CJ42
approved these changes
Oct 10, 2023
YamenMerhi
approved these changes
Oct 10, 2023
This was referenced Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR introduce?
🚀 Feature
PR Checklist
npm run lint&&npm run lint:solidity(solhint)npm run format(prettier)npm run buildnpm run test