Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add callee params to lsp20 & EXECUTE_RELAY_CALL permission & mapping reentrancyStatus #729
feat!: add callee params to lsp20 & EXECUTE_RELAY_CALL permission & mapping reentrancyStatus #729
Changes from 8 commits
0825ae3
7b27c64
79b7b06
b0552a4
f5bfd09
5b52316
62e2679
085dbad
5889edf
234fb6e
a0545ab
4a0696a
e72566b
ca9c9dd
69556c3
8736873
550b608
09c283e
32ae896
8cb66d4
91fcc47
685872c
7850888
7ae6051
8e9963c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to make the LSP20 modules reusable, I would suggest to parameterize in
_verifyCall
all the lsp20 functions parameter, because not in all scenarios the address(this) will be the target ormsg.sender
is the one to verify permissions for.But probably can be done in later PRs, just a note