Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sync main to release v0.12.0 #770

Merged
merged 13 commits into from
Oct 30, 2023
Merged

chore: sync main to release v0.12.0 #770

merged 13 commits into from
Oct 30, 2023

Conversation

CJ42
Copy link
Member

@CJ42 CJ42 commented Oct 30, 2023

What does this PR introduce?

Sync main branch to release v0.12.0 of the smart contracts, trigger via release-please.

YamenMerhi and others added 13 commits October 24, 2023 14:10
* test: fix tests of LSP1Delegate InterfaceId

* chore: remove .only

* test: add solidity tests for LSP1Delegate InterfaceId
…`owner()` and `target()` (#761)

* test: check owner + target of base contracts are `address(0)`

* test: add test for LSP7 / 8 Mintable Init
* refactor!: make notification optional in revokeOperator

* test: adjust the tests accordingly

* docs: generate docs

* chore: add override keyword

* chore: fix lsp7compatibleERC20

* refactor: include authorization status bool in lsp1 data in LSP8

* refactor!: allow increase allowance only when allowance > 0

* test: adjust the tests accoridngly

* docs: generate docs

* docs: generate docs
* feat!: create `Version` contract and inherit it

* docs: update auto generated docs
* refactor!: update LS8 Metadata keys to new LSP8 standard specs

* build: upgrade solc version used by Foundry
* feat!: add `ERC725X.executeBatch` path in Key Manager

* test: add tests for Batch Execute path via the Key Manager

* docs: update auto-generated docs

---------

Co-authored-by: CJ42 <cavallerajean@gmail.com>
Co-authored-by: Jean Cvllr <31145285+CJ42@users.noreply.github.com>
)

* perf: use `try / catch` in LSP20 to reduce runtime cost

Co-authored-by: b00ste.lyx <b00ste@users.noreply.github.com>

* perf: use `try / catch` in `_verifyCallResult`

* test: fix revert reason when `bytes4` returnStatus cannot be decoded

* docs: update ABI + internal functions docs

* refactor: replace error parameter to `bytes4`

---------

Co-authored-by: b00ste.lyx <b00ste@users.noreply.github.com>
Co-authored-by: b00ste <daniel@lukso.io>
* refactor!: replace ValueReceived with UniversalReceiver

* test: change ValueReceived to UniversalReceiver

* docs: replace reference of ValueReceived with UniversalReceiver

* test: add more tests

* chore: run prettier

* chore: add suggested changes

* feat: add payable bool to lsp17 extension

* test: add test forward value with lsp17

* refactor: update fallback in lsp0

* refactor: update lsp9 fallback

* refactor: update universalReceiver event in lsp0 & lsp9

* refactor: remame to isForwardingValue

* chore: fix wrong function name and improve code comments

* docs: update auto-generated docs

---------

Co-authored-by: Maxime <maximeviard@hotmail.fr>
Co-authored-by: CJ42 <cavallerajean@gmail.com>
Co-authored-by: Jean Cvllr <31145285+CJ42@users.noreply.github.com>
…lish on npm (#769)

* ci!: use `release-please` gh to publish on NPM + create Github release

* build: remove `standard-version` and `npm run release`
* build: deploy base contracts at pre-deterministic address

* build: use pre-defined salt
* refactor!: make notification optional in revokeOperator

* test: adjust the tests accordingly

* docs: generate docs

* chore: add override keyword

* chore: fix lsp7compatibleERC20

* refactor: include authorization status bool in lsp1 data in LSP8

* refactor!: allow increase allowance only when allowance > 0

* test: adjust the tests accoridngly

* docs: generate docs

* docs: generate docs

* chore: generate docs

* chore: add suggested changes

* refactor: cleanup library syntax with `using for`

* chore: fix JS linter warnings

* docs: update auto-generated docs

* test: fix failing tests

---------

Co-authored-by: CJ42 <cavallerajean@gmail.com>
Co-authored-by: Jean Cvllr <31145285+CJ42@users.noreply.github.com>
@CJ42 CJ42 merged commit 82c5633 into main Oct 30, 2023
57 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants