-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: set LSP4TokenType
on deployment of LSP7/8 Digital Assets
#806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CJ42
force-pushed
the
feat/lsp4-token-type
branch
from
November 23, 2023 16:32
72ca2e2
to
20189f5
Compare
Putting this back in draft, as some things are missing:
As follow: constructor(
string memory name_,
string memory symbol_,
address newOwner_,
uint256 lsp4TokenType_
uint256 lsp8TokenIdType_
) LSP4DigitalAssetMetadata(name_, symbol_, newOwner_, lsp4TokenType_) { |
CJ42
force-pushed
the
feat/lsp4-token-type
branch
2 times, most recently
from
November 24, 2023 16:45
1ff1de8
to
1085305
Compare
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
CJ42
force-pushed
the
feat/lsp4-token-type
branch
2 times, most recently
from
November 24, 2023 17:40
28ba988
to
88f57c3
Compare
CJ42
force-pushed
the
feat/lsp4-token-type
branch
from
November 24, 2023 17:51
88f57c3
to
00f9fce
Compare
skimaharvey
approved these changes
Nov 28, 2023
b00ste
approved these changes
Nov 28, 2023
contracts/LSP4DigitalAssetMetadata/LSP4DigitalAssetMetadata.sol
Outdated
Show resolved
Hide resolved
contracts/LSP4DigitalAssetMetadata/LSP4DigitalAssetMetadataInitAbstract.sol
Outdated
Show resolved
Hide resolved
6 tasks
This was referenced Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR introduce?
Add an extra parameter to the
constructor
/initialize(...)
functions of LSP4, LSP7 and LSP8 to setLSP4TokenType
on deployment.Add an extra parameter to the
constructor
/initialize(...)
functions of LSP8 to setLSP8TokenIdSchema
on deployment.🚀 Feature
0
), a NFT (1
) or a Collection (2
).These schemas can be one of the following:
♻️ Refactor
See the breaking change description above about
LSP4TokenType
andLSP8TokenIdSchema
set on deployment + make these data keys not editable after the contract has been deployed + initialized.PR Checklist
npm run lint
&&npm run lint:solidity
(solhint)npm run format
(prettier)npm run build
npm run test