Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [L-02] Missing virtual keyword on burn() in LSP8Burnable.sol #835

Merged
merged 2 commits into from
Jan 9, 2024
Merged

chore: [L-02] Missing virtual keyword on burn() in LSP8Burnable.sol #835

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0731b8a
chore: add `virtual` keyword in burn() in LSP8Burnable
YamenMerhi Jan 2, 2024
bc7bc39
Merge branch 'develop' into DEV-9440
CJ42 Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/LSP8IdentifiableDigitalAsset/extensions/LSP8Burnable.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ abstract contract LSP8Burnable is LSP8IdentifiableDigitalAsset {
* @param tokenId The tokenId to burn.
* @param data Any extra data to be sent alongside burning the tokenId.
*/
function burn(bytes32 tokenId, bytes memory data) public {
function burn(bytes32 tokenId, bytes memory data) public virtual {
if (!_isOperatorOrOwner(msg.sender, tokenId)) {
revert LSP8NotTokenOperator(tokenId, msg.sender);
}
Expand Down
Loading