-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [L-09] restrict owner change in _beforeTokenTransfer #846
Conversation
👋 Hello ⛽📊 Gas Benchmark ReportDeployment Costs
Runtime CostsUniversalProfile owned by an 🔑 EOA🔀
|
execute scenarios - UP owned by 🔑 EOA |
⛽ Gas Usage |
---|---|
Transfer 1 LYX to an EOA without data | 37572 (0 ) |
Transfer 1 LYX to a UP without data | 46265 (0 ) |
Transfer 1 LYX to an EOA with 256 bytes of data | 42245 (12 📈❌) |
Transfer 1 LYX to a UP with 256 bytes of data | 57198 (12 📈❌) |
Transfer 0.1 LYX to 3x EOA without data | 70898 (0 ) |
Transfer 0.1 LYX to 3x UP without data | 104489 (0 ) |
Transfer 0.1 LYX to 3x EOA with 256 bytes of data | 84898 (24 📈❌) |
Transfer 0.1 LYX to 3x UPs with 256 bytes of data | 137245 (-36 📉✅) |
🗄️ setData
scenarios
setData scenarios - UP owned by 🔑 EOA |
⛽ Gas Usage |
---|---|
Set a 20 bytes long value | 49921 (0 ) |
Set a 60 bytes long value | 95243 (0 ) |
Set a 160 bytes long value | 164391 (-24 📉✅) |
Set a 300 bytes long value | 279296 (0 ) |
Set a 600 bytes long value | 486656 (-24 📉✅) |
Change the value of a data key already set | 32809 (0 ) |
Remove the value of a data key already set | 27283 (0 ) |
Set 2 data keys of 20 bytes long value | 78428 (-12 📉✅) |
Set 2 data keys of 100 bytes long value | 260592 (-12 📉✅) |
Set 3 data keys of 20 bytes long value | 105128 (0 ) |
Change the value of three data keys already set of 20 bytes long value | 45428 (0 ) |
Remove the value of three data keys already set | 41325 (0 ) |
🗄️ Tokens
scenarios
Tokens scenarios - UP owned by 🔑 EOA |
⛽ Gas Usage |
---|---|
Minting a LSP7Token to a UP (No Delegate) from an EOA | 93114 (0 ) |
Minting a LSP7Token to an EOA from an EOA | 59390 (0 ) |
Transferring an LSP7Token from a UP to another UP (No Delegate) | 102367 (0 ) |
Minting a LSP8Token to a UP (No Delegate) from an EOA | 159961 (0 ) |
Minting a LSP8Token to an EOA from an EOA | 126238 (0 ) |
Transferring an LSP8Token from a UP to another UP (No Delegate) | 151147 (64 📈❌) |
UniversalProfile owned by a 🔒📄 LSP6KeyManager
🔀 execute
scenarios
execute scenarios |
👑 main controller | 🛃 restricted controller |
---|---|---|
LYX transfer --> to an EOA | 64365 (0 ) | 75316 (0 ) |
LYX transfer --> to a UP | 78508 (0 ) | 93410 (0 ) |
LSP7 token transfer --> to an EOA | 116872 (0 ) | 131622 (0 ) |
LSP7 token transfer --> to a UP | 250518 (0 ) | 265268 (0 ) |
LSP8 NFT transfer --> to an EOA | 181045 (64 📈❌) | 195795 (64 📈❌) |
LSP8 NFT transfer --> to a UP | 297893 (64 📈❌) | 312643 (64 📈❌) |
🗄️ setData
scenarios
setData scenarios |
👑 main controller | 🛃 restricted controller |
---|---|---|
Update Profile details (LSP3Profile Metadata) | 67264 (0 ) | 77286 (0 ) |
Add a new controller with permission to SET_DATA + 3x allowed data keys: AddressPermissions[] + AddressPermissions[index] + AddressPermissions:Permissions:<controller> + AddressPermissions:AllowedERC725YDataKeys:<controller ) |
209516 (0 ) | 219673 (0 ) |
Update permissions of previous controller. Allow it now to SUPER_SETDATA |
52292 (0 ) | 55298 (0 ) |
Remove a controller: 1. decrease AddressPermissions[] Array length 2. remove the controller address at AddressPermissions[index] 3. set "0x" for the controller permissions under AddressPermissions:Permissions: |
78765 (0 ) | 90064 (0 ) |
Write 5x new LSP12 Issued Assets | 66959 (0 ) | 101586 (0 ) |
Update 3x data keys (first 3) | 125411 (0 ) | 159515 (0 ) |
Update 3x data keys (middle 3) | 105499 (0 ) | 143669 (0 ) |
Update 3x data keys (last 3) | 125411 (0 ) | 169002 (0 ) |
Set 2 x new data keys + add 3x new controllers | 810121 (0 ) | 871921 (0 ) |
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
7499671
to
5e9bffd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added review comments
contracts/LSP8IdentifiableDigitalAsset/LSP8IdentifiableDigitalAssetCore.sol
Outdated
Show resolved
Hide resolved
e974a9e
to
35ddbd5
Compare
35ddbd5
to
a3560bc
Compare
…contracts into restrict-beforeTokenHook
1552c21
to
de8325f
Compare
1ff7365
to
b2abc5d
Compare
What does this PR introduce?