Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated typographical errors to improve readability #892

Merged
merged 2 commits into from
Jul 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ interface ILSP11BasicSocialRecovery {
event SecretHashChanged(bytes32 indexed secretHash);

/**
* @notice Emitted when a guardian select a new potentiel controller address for the target
* @notice Emitted when a guardian select a new potential controller address for the target
* @param recoveryCounter The current recovery process counter
* @param guardian The address of the guardian
* @param addressSelected The address selected by the guardian
Expand Down Expand Up @@ -119,7 +119,7 @@ interface ILSP11BasicSocialRecovery {
*
* Requirements:
*
* - The guardians count should be higher or equal to the guardain threshold
* - The guardians count should be higher or equal to the guardian threshold
*/
function removeGuardian(address currentGuardian) external;

Expand Down Expand Up @@ -147,7 +147,7 @@ interface ILSP11BasicSocialRecovery {
function setGuardiansThreshold(uint256 guardiansThreshold) external;

/**
* @dev select an address to be a potentiel controller address if he reaches
* @dev select an address to be a potential controller address if he reaches
* the guardian threshold and provide the correct secret string
*
* Requirements:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ abstract contract LSP11BasicSocialRecoveryCore is
// The guardians threshold
uint256 internal _guardiansThreshold;

// The number of successfull recovery processes
// The number of successful recovery processes
uint256 internal _recoveryCounter;

// The secret hash to be set by the owner
Expand Down Expand Up @@ -323,7 +323,7 @@ abstract contract LSP11BasicSocialRecoveryCore is
}

/**
* @dev Remove the guardians choice after a successfull recovery process
* @dev Remove the guardians choice after a successful recovery process
* To avoid keeping unnecessary state
*/
function _cleanStorage(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ contract KeyManagerInternalTester is LSP6KeyManager {
super._verifyPermissions(_target, from, false, payload);

// This event is emitted just for a sake of not marking this function as `view`,
// as Hardhat has a bug that does not catch error that occured from failed `abi.decode`
// as Hardhat has a bug that does not catch error that occurred from failed `abi.decode`
// inside view functions.
// See these issues in the Github repository of Hardhat:
// - https://github.com/NomicFoundation/hardhat/issues/3084
Expand Down
2 changes: 1 addition & 1 deletion packages/lsp14-contracts/contracts/LSP14Ownable2Step.sol
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ abstract contract LSP14Ownable2Step is ILSP14Ownable2Step, OwnableUnset {
uint256 public constant RENOUNCE_OWNERSHIP_CONFIRMATION_PERIOD = 200;

/**
* @dev The block number saved when initiating the process of renouncing ownerhsip.
* @dev The block number saved when initiating the process of renouncing ownership.
*/
uint256 internal _renounceOwnershipStartedAt;

Expand Down
2 changes: 1 addition & 1 deletion packages/lsp17-contracts/contracts/Extension4337.sol
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {
LSP17Extension
} from "@lukso/lsp17contractextension-contracts/contracts/LSP17Extension.sol";

// librairies
// libraries
import {ECDSA} from "@openzeppelin/contracts/utils/cryptography/ECDSA.sol";
import {LSP6Utils} from "@lukso/lsp6-contracts/contracts/LSP6Utils.sol";

Expand Down
2 changes: 1 addition & 1 deletion packages/lsp20-contracts/contracts/ILSP20CallVerifier.sol
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ pragma solidity ^0.8.4;
interface ILSP20CallVerifier {
/**
* @return returnedStatus MUST return the first 3 bytes of `lsp20VerifyCall(address,uint256,bytes)` function selector if the call to
* the function is allowed, concatened with a byte that determines if the lsp20VerifyCallResult function should
* the function is allowed, concatenated with a byte that determines if the lsp20VerifyCallResult function should
* be called after the original function call. The byte that invoke the lsp20VerifyCallResult function is strictly `0x01`.
*
* @param requestor The address that requested to make the call to `target`.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ contract LSP23LinkedContractsFactory is ILSP23LinkedContractsFactory {
* - the secondary contract addPrimaryContractAddress boolean
* - the secondary contract extra initialization params (if any)
* - the postDeploymentModule address
* - the callda to the post deployment module
* - the calldata to the post deployment module
*
*/
primaryContractProxyGeneratedSalt = keccak256(
Expand Down
Loading