Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build!: move @lukso/lsp-smart-contracts as its own package #894

Closed
wants to merge 48 commits into from
Closed

build!: move @lukso/lsp-smart-contracts as its own package #894

wants to merge 48 commits into from

Conversation

CJ42
Copy link
Member

@CJ42 CJ42 commented Feb 28, 2024

What does this PR introduce?

PR Checklist

  • Wrote Tests
  • Wrote & Generated Documentation (readme/natspec/dodoc)
  • Ran npm run lint && npm run lint:solidity (solhint)
  • Ran npm run format (prettier)
  • Ran npm run build
  • Ran npm run test

CJ42 and others added 30 commits February 15, 2024 14:46
@CJ42
build!: upgrade hardhat and ethers to v6
49af5a2
@CJ42
chore: update test helper and fixtures to ethers v6
131972c
@CJ42
test: refactor tests for UP, LSP3, LSP14 and LSP17
19081a7
@CJ42
test: refactor LSP2 and LSP11 for ethers v6
c4a9450
@CJ42
test: refactor tests to ethers v6 for LSP9 and LSP14
eff3f26
@CJ42
test: refactor tests to ethers v6 for LSP7 and LSP8
2631961
@CJ42
test: refactor LSP11 tests to ethers v6
54296ee
@CJ42
test: refactor LSP1 tests for ethers v6
1ade771
@CJ42
test: refactor LSP6 + LSP20 tests for ethers v6
3771bd4
@CJ42
test: refactor Reentrancy tests for ethers v6
993f9d9
@CJ42
test: refactor LSP1, Mocks and generic scripts
3a772c8
@CJ42
chore: replace paths and getSigHash by getFunction
83c1db1
@CJ42
test: fix more failing ethers v6 types and functions
07a60f9
@CJ42
Merge branch 'lsp-monorepo' into build/upgrade-dependencies
9dd9fc4
@CJ42
chore: remove user/dev docs from package.json
adb776e
@CJ42
chore: fix remaining failing tests in CI
b88acfc
@CJ42
chore: fix remaining failing tests in CI
462a5de
@CJ42
chore: fix tests for missing LSP1 Delegate permissions
f74db97
@CJ42
chore: update incorrect path for contract artifact
57f818d
@CJ42
chore: fix remaining tests
77bb2c5
@b00ste @CJ42
refactor: migrate Create2Factory to ethers v6
4d7bf33
@CJ42
Merge branch 'lsp-monorepo' into build/upgrade-dependencies
a16853e
@CJ42
test: skip lsp17extensions test because of NickFactory deployment e…
f38759f 
…rror
@CJ42
chore: upgrade deployment scripts to ethers v6
175ae97
@CJ42
build: resolve dependency resolution for hardhat-packager and `@typ…
2a6c777 
…echain/hardhat`
@CJ42
chore: delete dev-dependency in packages to keep only those at root
17bba8d
@CJ42
chore!: move @lukso/lsp-smart-contracts in its own package
e3d6324
@CJ42
build: move all the build and config files into `packages/lsp-smart-c…
a83a12b 
…ontracts`
@CJ42
test: move all the tests/ under packages/lsp-smart-contracts
f4fc047
@CJ42
build: organise package.json for root and @lukso/lsp-smart-contracts
3f716dc
CJ42 and others added 13 commits February 28, 2024 04:14
@CJ42
build: cleanup test and scripts commands from root to package
2e912fc
@CJ42
ci: adjust CI for build lint test for all packages
1445310
@CJ42
chore: remap import paths for LSP0ERC725Account to `@lukso/lsp0-con…
e2e2d30 
…tracts/`
@CJ42
chore: remap import paths for LSP2ERC75YJSONSchema to `@lukso/lsp2-…
e7197ce 
…contracts/`
@CJ42
ci: update CI job path runner for solc_version
906f3b9
@CJ42
build: tmp turn off global import disallowed in .sol file for `lsp-…
9b10b45 
…smart-contracts`
@b00ste
chore: remap import paths
d3b06ba
@CJ42
test: fix Benchmark tests for ethers v6 syntax
1873dc9
@CJ42
chore: fix some Solidity import path compiler errors
131cbc5
@CJ42
build: update package-lock.json
44f199a
@CJ42
test: update foundry tests setting for @lukso/lsp-smart-contracts
0fc6d7b
@CJ42
chore: add missing environnement variable in turbo.json
bd41894
@b00ste
test: repair tests that import helpers from root
5378c3a
@b00ste b00ste force-pushed the package/lukso-lsp-smart-contracts branch from 971bf80 to 5378c3a Compare February 28, 2024 18:37
@CJ42 CJ42 force-pushed the package/lukso-lsp-smart-contracts branch 3 times, most recently from 4df8747 to bd4806c Compare February 29, 2024 00:01
@CJ42 CJ42 force-pushed the package/lukso-lsp-smart-contracts branch from bd4806c to 25ba134 Compare February 29, 2024 00:03
@CJ42 CJ42 force-pushed the package/lukso-lsp-smart-contracts branch from d967134 to 207b816 Compare February 29, 2024 00:40
@CJ42 CJ42 marked this pull request as ready for review February 29, 2024 00:48
skimaharvey
skimaharvey approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@skimaharvey skimaharvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from build/upgrade-dependencies to lsp-monorepo February 29, 2024 18:27
@CJ42 CJ42 force-pushed the package/lukso-lsp-smart-contracts branch from d3fc765 to 1a00ad2 Compare February 29, 2024 20:53
@CJ42
Copy link
Member Author

CJ42 commented Mar 1, 2024

Closed in favour of #896

@CJ42 CJ42 closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skimaharvey skimaharvey skimaharvey approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CJ42 @skimaharvey @b00ste