Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ERCTokenCallbacks Extension #972

Merged
merged 2 commits into from
Oct 23, 2024
Merged

feat: add ERCTokenCallbacks Extension #972

merged 2 commits into from
Oct 23, 2024

Conversation

YamenMerhi
Copy link
Member

Add an extension for all major token callbacks

skimaharvey
skimaharvey approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@skimaharvey skimaharvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/lsp17-contracts/contracts/ERCTokenCallbacks.sol
IERC777Recipient,
LSP17Extension
{
function tokensReceived(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding a 777 comment would be nice

CJ42
CJ42 requested changes Sep 2, 2024
View reviewed changes
Copy link
Member

@CJ42 CJ42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ideally we should add some basic tests to ensure these work and don't revert on ERC token transfers with the callback hooks.

CJ42
CJ42 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@CJ42 CJ42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge and add the tests for this after. As we need to unlock to get the repo back in working state with only main

@CJ42 CJ42 merged commit c838a67 into develop Oct 23, 2024
2 checks passed
@CJ42 CJ42 deleted the erccallbacks branch October 23, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CJ42 CJ42 CJ42 approved these changes

@skimaharvey skimaharvey skimaharvey approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YamenMerhi @CJ42 @skimaharvey