feat: Add LSP7Votes and LSP8Votes extension to support LSP-based Governance #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CJ42
reviewed
Oct 21, 2024
| force: force, | ||
| data: data | ||
| }); | ||
| _update(address(0), to, amount, force, data); |
There was a problem hiding this comment.
Let's wait for #974 to be merged first, as the Core contract does not exist anymore,
| if (fromBalance < value) { | ||
| revert LSP7AmountExceedsBalance(fromBalance, from, value); | ||
| } | ||
| unchecked { |
| */ | ||
| function checkpoints( | ||
| address account, | ||
| uint32 pos |
There was a problem hiding this comment.
What does pos stands for? Suggest a more explicit param name
CJ42
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR introduce?
🚀 Feature
PR Checklist
npm run lint&&npm run lint:solidity(solhint)npm run format(prettier)npm run buildnpm run test