Minor improvements #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhildeb
approved these changes
Feb 2, 2024
| ## Contents | ||
|
|
||
| - [`convenience`](./convenience): Address Checks and EOA creation | ||
| - [`create-profile`](./create-profile): Universal Profile Creation | ||
| - [`universal-profile`](./universal-profile): Universal Profile |
There was a problem hiding this comment.
Suggested change
| - [`universal-profile`](./universal-profile): Universal Profile | |
| - [`universal-profile`](./universal-profile): Universal Profile Creation and Interaction |
I am not 100% sure about the description, but it should indicate what to expect within the folder.
| @@ -8,7 +7,7 @@ import KeyManager from '@lukso/lsp-smart-contracts/artifacts/LSP6KeyManager.json | |||
| // Static variables | |||
| const RPC_ENDPOINT = 'https://rpc.testnet.lukso.gateway.fm'; | |||
| const IPFS_GATEWAY = 'https://api.universalprofile.cloud/ipfs'; | |||
| const CHAIN_ID = 2828; | |||
| const CHAIN_ID = 4201; | |||
There was a problem hiding this comment.
haha, good catch ✅
If this is (or we have) a script for dApp devs, maybe these should not be static.
import { ethers } from 'ethers';
const provider = new ethers.BrowserProvider(window.lukso);
const {chainId } = provider.getNetwork()
const universalProfileAddress = await provider.send('eth_requestAccounts', []);Just as a side note.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.