Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LSP4 Metadata for EOAs #33

Merged
merged 4 commits into from
Feb 9, 2024
Merged

Update LSP4 Metadata for EOAs #33

merged 4 commits into from
Feb 9, 2024

Conversation

fhildeb
Copy link
Contributor

@fhildeb fhildeb commented Feb 9, 2024

No description provided.

@fhildeb fhildeb requested review from Hugoo and CJ42 February 9, 2024 13:04
@fhildeb fhildeb changed the title Sync LSP7 deployment with docs guide Create LSP4 Metadata Guide for EOAs Feb 9, 2024
@fhildeb fhildeb mentioned this pull request Feb 9, 2024
6 tasks
@fhildeb fhildeb changed the title Create LSP4 Metadata Guide for EOAs Create Guide to update LSP4 Metadata for EOAs Feb 9, 2024
@fhildeb fhildeb changed the title Create Guide to update LSP4 Metadata for EOAs Update LSP4 Metadata for EOAs Feb 9, 2024
Copy link
Contributor

@Hugoo Hugoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ill merge but it would be nice to put the address in a var imo

console.log('Token metadata updated:', receipt);
}

attachAssetMetadata('0xdb86734b1e27F9A1e73627af6238171BD7d3716C')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to put this address in a variable and to give it a name

Is it mainnet? testnet?

Suggested change
attachAssetMetadata('0xdb86734b1e27F9A1e73627af6238171BD7d3716C')
const XXX_TESTNET_ADDRESS = '0xdb86734b1e27F9A1e73627af6238171BD7d3716C';
attachAssetMetadata(XXX_TESTNET_ADDRESS)

@Hugoo Hugoo merged commit ebe5d33 into main Feb 9, 2024
1 check passed
@Hugoo Hugoo deleted the sync-script-w-docs branch February 9, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants