Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop Pascalizing Enum Cases #162

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Stop Pascalizing Enum Cases #162

wants to merge 9 commits into from

Commits on Apr 20, 2024

  1. Fix derive macros on enums missing newline

    @lkirkwood
    lkirkwood committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    97a6a63 View commit details
    Browse the repository at this point in the history

  2. Stop pascalizing enum case name to avoid clashes 

    Pascalizing enum case names in restrictions can cause clashes (see lumeohq#154)
    @lkirkwood
    lkirkwood committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    2a97fcd View commit details
    Browse the repository at this point in the history

  3. Updated enumeration tests after pascalize change

    @lkirkwood
    lkirkwood committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    0fccc9c View commit details
    Browse the repository at this point in the history

  4. Updated union tests after pascalize change

    @lkirkwood
    lkirkwood committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    93d699c View commit details
    Browse the repository at this point in the history

  5. Allowed non_camel_case_types on enums 

    Added this macro because enums which contain non-pascalized cases due to
2a97fcd would trigger a clippy lint.
    @lkirkwood
    lkirkwood committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    ca1cac5 View commit details
    Browse the repository at this point in the history

  6. Updated enum/union tests after adding allow macro

    @lkirkwood
    lkirkwood committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    5e9a0b6 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2024

  1. Silence clippy warning

    @lkirkwood
    lkirkwood committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    938809c View commit details
    Browse the repository at this point in the history

  2. Allowed clippy::upper_case_acronyms on enums 

    Much the same as non_camel_case_types but clippy will still complain
without this.
    @lkirkwood
    lkirkwood committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    56642df View commit details
    Browse the repository at this point in the history

  3. Updated tests after allowing upper_case_acronyms

    @lkirkwood
    lkirkwood committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    e754ded View commit details
    Browse the repository at this point in the history