Support python 3.12 / notebook>=7 and drop support for python 3.9. #646
Conversation
JoepVanlier
changed the title
JoepVanlier
changed the title
changelog.md
Outdated
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| #### New features | |||
|
|
|||
| * Support Python `3.12`. | |||
There was a problem hiding this comment.
You may want to mention dropping 3.9 in the same line. Feels kinda natural. "Added support for Python 3.12, dropped support for 3.9."
setup.py
Outdated
| "jupyter_client<8", # https://github.com/jupyter/notebook/issues/6748 | ||
| "pyzmq<25", # https://github.com/jupyter/notebook/issues/6748 | ||
| "jupyter_client>=8", | ||
| "ipympl", |
There was a problem hiding this comment.
It would be nice to have some minimum defined here.
There was a problem hiding this comment.
Yeah, good catch on this front actually, since we need the latest ipympl for the version of matplotlib that we are using.
setup.py
Outdated
| "pyzmq<25", # https://github.com/jupyter/notebook/issues/6748 | ||
| "jupyter_client>=8", | ||
| "ipympl", | ||
| "pyzmq", |
There was a problem hiding this comment.
Is pyzmq even needed here anymore? It's not a direct dependency and we don't pin it. So probably doesn't even need to be in the list.
Is there a particular configuration or installation procedure that you are worried about? I have tested this on three machines. My desktop at home (Windows, w/pip), my DELL at work (Windows, both pip and conda) and my work mac (MacOS with pip inside a conda environment and with conda itself). I also tried installing the dependencies for the last version of Pylake on Windows and then updating to the latest and that also worked. To me it seems like it would lead to diminishing returns unless we know specifically what configuration we want to test. Especially since that to install latest (prior to release), the installation method is always going to be slightly different than what we would truly have on a release. |
we should be able to simplify these now that upstream issues have been fixed
resolves deprecation warnings related to nodejs
Why this PR?
It's good to stay relatively up to date with Python versions. This PR drops support for Python
3.9and adds support for3.12.We could consider keeping
3.9for one more release and immediately drop it on the next (to ease any transition issues) or just rip the band-aid off now. I have a mild preference for the latter, since3.9is old, and all the dependency changes we are already doing forjupyter notebookmight require a new environment for some anyway.Jupyter
With
3.12comes a necessary change, which is the switch to jupyternotebook>=7. Reason being thatnotebook<7pins us topyzmq<25. For a while, they added this pin officially, but they have since dropped this since binaries forpyzmq<25are not being created for python 3.12 and this effectively locks you into old versions of python. That said, I did do a bunch of testing, and for us, without the pin, I still getUncaught exception in ZMQStream callbackafter a while on windows, after which the interactive widgets stop working responding entirely (this is the issue that was the original reason for the pin).We should update. I have tested the latest installation instructions with
notebook>7onconda/windows,pip/windowsandpip/macand I think we should just do it. If there are issues, we will resolve them as they come. Staying with something that is essentially deprecated is just kicking the can down the road.Interactive widget
Since we do want interactive widgets, I have added
ipymplas an extra dependency.Note that this means using the magic
%matplotlib widgetrather than%matplotlib notebook.conda
I have also dropped some of the special conda instructions in the installation guide, as it seems they are also no longer needed.
Docs build here. Most relevant is probably the FAQ.
Note that the tests aren't green because the
3.9action isn't being run any more. I will flip the switch on that once I get a greenlight on this PR.