Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cleanup] Refactor Tables for code reuse, readability and cleanup #70

Open
mamy-CS opened this issue Jul 8, 2021 · 1 comment
Open

[cleanup] Refactor Tables for code reuse, readability and cleanup #70

mamy-CS opened this issue Jul 8, 2021 · 1 comment
Assignees
@mamy-CS
Labels
moved

Comments

@mamy-CS
Copy link
Collaborator

mamy-CS commented Jul 8, 2021 •
edited by lumjjb
Loading

Some UI components are reusable but copy-pasted, these should be addressed throughout the code

Currently - Multiple tables with same code.
To-Do - Code reuse, one table class, and reuse for all tables.
Breakdown in classes for readability [Investigate further for best implementation]
@mamy-CS mamy-CS self-assigned this Jul 8, 2021
@lumjjb lumjjb mentioned this issue Jul 8, 2021
Merged
@lumjjb
Copy link
Owner

lumjjb commented Aug 17, 2021

Reference discussion: https://github.com/lumjjb/tornjak/pull/66#discussion_r665607810

@lumjjb lumjjb changed the title Refactor Tables for code reuse, readability and cleanup [cleanup] Refactor Tables for code reuse, readability and cleanup Aug 17, 2021
@lumjjb lumjjb mentioned this issue Aug 17, 2021
Closed
@lumjjb lumjjb added the moved label Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mamy-CS mamy-CS

Labels
moved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lumjjb @mamy-CS