Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster managment front end UI #66

Merged
merged 21 commits into from
Jul 8, 2021

Conversation

mamy-CS
Copy link
Collaborator

@mamy-CS mamy-CS commented Jun 16, 2021

@mamy-CS mamy-CS self-assigned this Jun 16, 2021
@mamy-CS mamy-CS linked an issue Jun 16, 2021 that may be closed by this pull request
3 tasks
tornjak-frontend/src/res/data.js Outdated Show resolved Hide resolved
tornjak-frontend/src/components/cluster-create.js Outdated Show resolved Hide resolved
tornjak-frontend/src/components/cluster-create.js Outdated Show resolved Hide resolved
tornjak-frontend/src/components/cluster-edit.js Outdated Show resolved Hide resolved
@mamy-CS mamy-CS force-pushed the cluster-managment-front-end-ui branch from 7200832 to caa448d Compare June 23, 2021 19:24
Copy link
Collaborator

@maia-iyer maia-iyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of fixes to make the backend and frontend work together!
Extra possible feature as a small work-in: deleteCluster. This could be a separate api call? or part of Edit?

tornjak-frontend/src/components/cluster-create.js Outdated Show resolved Hide resolved
tornjak-frontend/src/components/cluster-create.js Outdated Show resolved Hide resolved
tornjak-frontend/src/components/cluster-create.js Outdated Show resolved Hide resolved
tornjak-frontend/src/components/cluster-edit.js Outdated Show resolved Hide resolved
tornjak-frontend/src/components/cluster-edit.js Outdated Show resolved Hide resolved
tornjak-frontend/src/components/cluster-edit.js Outdated Show resolved Hide resolved
tornjak-frontend/src/components/cluster-edit.js Outdated Show resolved Hide resolved
tornjak-frontend/src/components/tornjak-api-helpers.js Outdated Show resolved Hide resolved
tornjak-frontend/src/components/tornjak-api-helpers.js Outdated Show resolved Hide resolved
tornjak-frontend/src/redux/reducers/clustersReducer.js Outdated Show resolved Hide resolved
this.prepareAgentsList = this.prepareAgentsList.bind(this);
this.state = {
clusterTypeList: [],
agentsList: [],
Copy link
Owner

@lumjjb lumjjb Jul 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's special about this agent list? does it need to be in a state?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the agentList that is prepared for the multiselect in assigning agents for cluster create and edit. It has to be a specific format.

Copy link
Owner

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lumjjb lumjjb merged commit 6c126e3 into lumjjb:main Jul 8, 2021
lumjjb pushed a commit that referenced this pull request Aug 9, 2021
Cluster management front end UI

Signed-off-by: Mohammed Abdi <mohammed.munir.abdi@ibm.com>
lumjjb pushed a commit that referenced this pull request Aug 9, 2021
Cluster management front end UI

Signed-off-by: Mohammed Abdi <mohammed.munir.abdi@ibm.com>
lumjjb pushed a commit that referenced this pull request Aug 9, 2021
Cluster management front end UI

Signed-off-by: Mohammed Abdi <mohammed.munir.abdi@ibm.com>
lumjjb pushed a commit that referenced this pull request Aug 9, 2021
Cluster management front end UI

Signed-off-by: Mohammed Abdi <mohammed.munir.abdi@ibm.com>
lumjjb pushed a commit that referenced this pull request Aug 9, 2021
Cluster management front end UI

Signed-off-by: Mohammed Abdi <mohammed.munir.abdi@ibm.com>
lumjjb pushed a commit that referenced this pull request Aug 9, 2021
Cluster management front end UI

Signed-off-by: Mohammed Abdi <48661743+mamy-CS@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cluster Management Front End [UI]
3 participants