-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cluster managment front end UI #66
Conversation
7200832
to
caa448d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple of fixes to make the backend and frontend work together!
Extra possible feature as a small work-in: deleteCluster. This could be a separate api call? or part of Edit?
this.prepareAgentsList = this.prepareAgentsList.bind(this); | ||
this.state = { | ||
clusterTypeList: [], | ||
agentsList: [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's special about this agent list? does it need to be in a state?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the agentList that is prepared for the multiselect in assigning agents for cluster create and edit. It has to be a specific format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Cluster management front end UI Signed-off-by: Mohammed Abdi <mohammed.munir.abdi@ibm.com>
Cluster management front end UI Signed-off-by: Mohammed Abdi <mohammed.munir.abdi@ibm.com>
Cluster management front end UI Signed-off-by: Mohammed Abdi <mohammed.munir.abdi@ibm.com>
Cluster management front end UI Signed-off-by: Mohammed Abdi <mohammed.munir.abdi@ibm.com>
Cluster management front end UI Signed-off-by: Mohammed Abdi <mohammed.munir.abdi@ibm.com>
Cluster management front end UI Signed-off-by: Mohammed Abdi <48661743+mamy-CS@users.noreply.github.com>
https://github.com/lumjjb/tornjak/issues/65