Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to see changed rule numbers #21

Open
KingSupernova31 opened this issue May 29, 2023 · 4 comments
Open

Add a way to see changed rule numbers #21

KingSupernova31 opened this issue May 29, 2023 · 4 comments

Comments

@KingSupernova31
Copy link

The current diffs only show rule text that changed, not rule numbers. For example, in The Brothers' War, the addition of section 719 on prototype cards caused every rule in the former sections 719-728 to get bumped down 1 number. The addition of individual rules can also cause smaller renumberings within a section or subsection.

This is irrelevant to most people who are looking at the diffs, but it's extremely important for those of us trying to maintain accurate rule references, such as the RulesGuru team and Judge Academy. Right now I use https://text-compare.com/ to find all the changes, but it would be nice if AR provided that too.

Listing every single changed rule in the displayed diff would obviously be terrible, so I would suggest simply adding a line in the diff under any new section that says "subsequent rules renumbered" or something like that.

It would also be nice if the API provided a full list of renumbered rules, which would allow RulesGuru and similar resources to update its references automatically.

@lunakv
Copy link
Owner

lunakv commented May 30, 2023

I don't think that's something I want to display as part of the diff. For one thing, it would either have to be just a plain list - and given that only the change you mentioned covers 85 rule numbers, that's not ideal - or it would have to be manually curated, which goes against what I'm trying to do with the project. Or I guess I could just call ChatGPT to summarize the changes for me 🙂.

I'm not indifferent to the idea as an optional setting at some point, but I don't think it's good default and it probably needs some more time spent on the execution.

That said, I have absolutely no problem exposing that data in the API once it's actually tracked. It's a prerequisite for the trace functionality (lunakv/academyruins-api#9) anyways, so it won't be too much extra work to include it directly in some endpoint.

@KingSupernova31
Copy link
Author

For one thing, it would either have to be just a plain list - and given that only the change you mentioned covers 85 rule numbers, that's not ideal - or it would have to be manually curated, which goes against what I'm trying to do with the project.

I'm a bit confused; isn't this what I addressed here?

Listing every single changed rule in the displayed diff would obviously be terrible, so I would suggest simply adding a line in the diff under any new section that says "subsequent rules renumbered" or something like that.

It wouldn't have to be manual; if AR can detect when a new rule has been added or an old rule removed, all it needs to do is say that that's happened. For example in the most recent update where 713 was removed, all it needs to say is "rule 713 removed, rules 714-729 decremented" or something like that. (And of course also cover a rule being moved from one section to another.)

@lunakv
Copy link
Owner

lunakv commented May 30, 2023

That's kind of my point though. Coming up with "rule 713 removed, rules 714-729 decremented" automatically from a list of number changes is far from trivial to do generally, and I'm not sure it's an effort I want to spend.

@KingSupernova31
Copy link
Author

Oh hey, here's a funny corner case: In the MOM update, Wizards accidentally started section 712.3's subrules with "d" rather than "a". This was fixed in the LTR update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants