Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observation: The number of reticulations depends on the chosen brlen linkage mode (and maybe also on the likelihood model) #33

Open
lutteropp opened this issue Dec 17, 2020 · 7 comments

Comments

@lutteropp
Copy link
Owner

This example network shows that the displayed trees of a network can have identical topology:
3

In here, only a single branch length can differ between the two displayed trees.

In unlinked brlens mode, each partition has its own branch lengths. Thus for the unlinked brlens mode it makes no sense to have a reticulation here. The reticulation makes sense in linked branch lengths mode (but there, mostly for LikelihoodModel.BEST, as the advantage of the variable branch length has some negative influences in LikelihoodModel.AVERAGE). For scaled branch lengths mode, it is still a bit unclear for me what should ideally happen in the inference.

@lutteropp
Copy link
Owner Author

In LikelihoodModel.AVERAGE, the negative influence comes from the reticulation probabilities being always linked among all partitions. We would not have a negative influence here if each partition would have its own reticulation probabiities.

@celinescornavacca
Copy link
Collaborator

Today I notice that I understand well the difference between LikelihoodModel.BEST and LikelihoodModel.AVERAGE but I am not sure I understand UNLINKED, LINKED and SCALED.

When we have a tree and and we have LINKED, any gene of a partition has the same tree and the same branch lengths.
When we have a tree and and we have SCALED, any gene of a partition has the same tree and the same branch lengths, ignoring a multiplication factor (the mutation rates vary among gene).
When we have a tree and and we have UNLINKED, any gene of a partition has the same tree but the branch lengths can vary (mutation rates vary among genes and branches).

@stamatak, am I right? Sorry to ask stupid things, but better safe than sorry.

In my simulation we are in the LINKED case for now (we we could easily have SCALED for the next article), so I do not see why we should have UNLINKED in the reconstruction.

Also, it would be good to add a step to the simulations, if you both agree: since branch lengths and inheritance probabilities are bothering us, how about running netRax on the true topology to see how good we are at estimating branch lengths and inheritance probabilities under the 6 combinations of BEST and AVERAGE x UNLINKED, LINKED and SCALED?

@stamatak
Copy link
Collaborator

stamatak commented Dec 18, 2020 via email

@celinescornavacca
Copy link
Collaborator

Here UNLINKED is applied to networks, not displayed trees right?
If so, my rationale is that having the same branch lengths for the same network topology for all partitions will give us more power to infer reticulations

@stamatak
Copy link
Collaborator

stamatak commented Dec 19, 2020 via email

@lutteropp
Copy link
Owner Author

lutteropp commented Jan 18, 2021

Cool! Then we can do all experiments in LINKED mode! :-) This one also performed best in the anecdotal experience I had so far. I believe (from reading the simulator code) the network simulations are using LINKED branch lengths as well.

@celinescornavacca
Copy link
Collaborator

The simulator simulates an ultrametric networks and extracts displayed trees out of the simulated network, one for partition.
Then simulates sequences on the output displayed trees.

To be sure to get it right, let' s look at this pics:
photo_2021-01-19_10-00-19

Suppose that we simulate 2 partitions, one along T1 and one along T2.
The LINKED mode says that the brl of T1 and those of T2 have to be the same in the first and the second partition (so brl T1 in P1=brl T1 in P2 AND brl T2 in P1=brl T2 in P2), right?
[note that it is totally OK to have T1 and T2 to have the same topology, but they have to be treated as different trees]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants