Colorize edge with int data type #1303
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will colorize edge with int data type. This is to better visualize quantized models.
|
sample capture of Quantize_001.zip tflite model
|
seanshpark
commented
Jun 17, 2024
Comment on lines
+72
to
+75
| .edge-path-b4 { stroke: #70e; stroke-width: 1x; fill: none; marker-end: url("#arrowhead"); } | ||
| .edge-path-b8 { stroke: #04e; stroke-width: 1px; fill: none; marker-end: url("#arrowhead"); } | ||
| .edge-path-b16 { stroke: #080; stroke-width: 1px; fill: none; marker-end: url("#arrowhead"); } | ||
| .edge-path-b32 { stroke: #992; stroke-width: 1px; fill: none; marker-end: url("#arrowhead"); } |
There was a problem hiding this comment.
I'm not good at colors. Please choose with your preference :)
There was a problem hiding this comment.
Can you please work with a designer to address this.
kylesayrs
reviewed
Jun 21, 2024
kylesayrs
reviewed
Jun 21, 2024
| }; | ||
| const edgePathClass = (dataType) => { | ||
| const dt = dataType.toLowerCase(); | ||
| if (dt === 'uint8' || dt === 'int8') { |
There was a problem hiding this comment.
nit: may consider swapping to a switch statement here
kylesayrs
reviewed
Jun 21, 2024
|
@kylesayrs , thanks for the suggestion ! |
lutzroeder
requested changes
Jun 22, 2024
There was a problem hiding this comment.
A few questions:
- There are many more data types, why hardcode this set and how would this extend to other types?
- Could this be overwhelming or confusing to other users?
- Would two styles be enough if the problem is separating int and float?
- What other solutions might work to solve this?
lutzroeder
force-pushed
the
main
branch
3 times, most recently
from
947fe42
to
09bd794
Compare
lutzroeder
force-pushed
the
main
branch
9 times, most recently
from
e02cf71
to
a805f35
Compare
|
Please comment with additional information if the pull request should be reopened. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will colorize edge with int data type.
This is to better visualize quantized models.