feat(draw_sw): add image clip_radius and mask before transformation #7244
+2,034
−1,546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisvegabor
force-pushed
the
fix/mask-rot
branch
from
49622c8
to
490a07c
Compare
kisvegabor
force-pushed
the
fix/mask-rot
branch
from
490a07c
to
17d0c2b
Compare
kisvegabor
commented
Nov 6, 2024
tests/ref_imgs/draw/c_array_image_stride1_UNCOMPRESSED_recolor.png
Outdated
Show resolved
Hide resolved
MarkIoanAmat
approved these changes
Nov 14, 2024
|
@liamHowatt @FASTSHIFT @XuNeo please review this PR. |
liamHowatt
reviewed
Nov 18, 2024
Comment on lines
1115
to
+1119
| bool area_need_alpha = alpha_test_area_on_obj(obj, &layer_area_act); | ||
|
|
||
| const void * bitmap_mask_src = lv_obj_get_style_bitmap_mask_src(obj, 0); | ||
| if(bitmap_mask_src) area_need_alpha = true; | ||
|
|
There was a problem hiding this comment.
Can we avoid calling alpha_test_area_on_obj if we know bitmap_mask_src != NULL?
Suggested change
| bool area_need_alpha = alpha_test_area_on_obj(obj, &layer_area_act); | |
| const void * bitmap_mask_src = lv_obj_get_style_bitmap_mask_src(obj, 0); | |
| if(bitmap_mask_src) area_need_alpha = true; | |
| const void * bitmap_mask_src = lv_obj_get_style_bitmap_mask_src(obj, 0); | |
| bool area_need_alpha = bitmap_mask_src || alpha_test_area_on_obj(obj, &layer_area_act); |
|
@FASTSHIFT I've implemented bg_image radius clipping and added some tests. I've noticed that VG-Lite clips them incorrectly:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It required a larger restructuring in image drawing so I'm mainly relying on the CI.
Notes
lv_conf_template.hrun lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py(astyle v3.4.12needs to installed by runningcd scripts; ./install_astyle.sh) and follow the Code Conventions.