Skip to content

Commit

Permalink
Merge branch '2.3' into 2.7
Browse files Browse the repository at this point in the history
* 2.3:
  removed all @Covers annotations
  [PropertyAccess] Major performance improvement
  • Loading branch information
fabpot committed Nov 2, 2015
2 parents 06ecd0c + be39e9b commit b33593c
Showing 1 changed file with 0 additions and 47 deletions.
47 changes: 0 additions & 47 deletions Tests/CrawlerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ public function testConstructor()
$this->assertCount(1, $crawler, '__construct() takes a node as a first argument');
}

/**
* @covers Symfony\Component\DomCrawler\Crawler::add
*/
public function testAdd()
{
$crawler = new Crawler();
Expand Down Expand Up @@ -63,9 +60,6 @@ public function testAddInvalidNode()
$crawler->add(1);
}

/**
* @covers Symfony\Component\DomCrawler\Crawler::addHtmlContent
*/
public function testAddHtmlContent()
{
$crawler = new Crawler();
Expand All @@ -80,7 +74,6 @@ public function testAddHtmlContent()
}

/**
* @covers Symfony\Component\DomCrawler\Crawler::addHtmlContent
* @requires extension mbstring
*/
public function testAddHtmlContentCharset()
Expand All @@ -91,9 +84,6 @@ public function testAddHtmlContentCharset()
$this->assertEquals('Tiếng Việt', $crawler->filterXPath('//div')->text());
}

/**
* @covers Symfony\Component\DomCrawler\Crawler::addHtmlContent
*/
public function testAddHtmlContentInvalidBaseTag()
{
$crawler = new Crawler(null, 'http://symfony.com');
Expand All @@ -103,9 +93,6 @@ public function testAddHtmlContentInvalidBaseTag()
$this->assertEquals('http://symfony.com/contact', current($crawler->filterXPath('//a')->links())->getUri(), '->addHtmlContent() correctly handles a non-existent base tag href attribute');
}

/**
* @covers Symfony\Component\DomCrawler\Crawler::addHtmlContent
*/
public function testAddHtmlContentUnsupportedCharset()
{
$crawler = new Crawler();
Expand All @@ -115,7 +102,6 @@ public function testAddHtmlContentUnsupportedCharset()
}

/**
* @covers Symfony\Component\DomCrawler\Crawler::addHtmlContent
* @requires extension mbstring
*/
public function testAddHtmlContentCharsetGbk()
Expand All @@ -127,9 +113,6 @@ public function testAddHtmlContentCharsetGbk()
$this->assertEquals('中文', $crawler->filterXPath('//p')->text());
}

/**
* @covers Symfony\Component\DomCrawler\Crawler::addHtmlContent
*/
public function testAddHtmlContentWithErrors()
{
$internalErrors = libxml_use_internal_errors(true);
Expand All @@ -155,9 +138,6 @@ public function testAddHtmlContentWithErrors()
libxml_use_internal_errors($internalErrors);
}

/**
* @covers Symfony\Component\DomCrawler\Crawler::addXmlContent
*/
public function testAddXmlContent()
{
$crawler = new Crawler();
Expand All @@ -166,9 +146,6 @@ public function testAddXmlContent()
$this->assertEquals('foo', $crawler->filterXPath('//div')->attr('class'), '->addXmlContent() adds nodes from an XML string');
}

/**
* @covers Symfony\Component\DomCrawler\Crawler::addXmlContent
*/
public function testAddXmlContentCharset()
{
$crawler = new Crawler();
Expand All @@ -177,9 +154,6 @@ public function testAddXmlContentCharset()
$this->assertEquals('Tiếng Việt', $crawler->filterXPath('//div')->text());
}

/**
* @covers Symfony\Component\DomCrawler\Crawler::addXmlContent
*/
public function testAddXmlContentWithErrors()
{
$internalErrors = libxml_use_internal_errors(true);
Expand All @@ -203,9 +177,6 @@ public function testAddXmlContentWithErrors()
libxml_use_internal_errors($internalErrors);
}

/**
* @covers Symfony\Component\DomCrawler\Crawler::addContent
*/
public function testAddContent()
{
$crawler = new Crawler();
Expand Down Expand Up @@ -241,9 +212,6 @@ public function testAddContent()
$this->assertEquals('日本語', $crawler->filterXPath('//body')->text(), '->addContent() can recognize "Shift_JIS" in html5 meta charset tag');
}

/**
* @covers Symfony\Component\DomCrawler\Crawler::addDocument
*/
public function testAddDocument()
{
$crawler = new Crawler();
Expand All @@ -252,9 +220,6 @@ public function testAddDocument()
$this->assertEquals('foo', $crawler->filterXPath('//div')->attr('class'), '->addDocument() adds nodes from a \DOMDocument');
}

/**
* @covers Symfony\Component\DomCrawler\Crawler::addNodeList
*/
public function testAddNodeList()
{
$crawler = new Crawler();
Expand All @@ -263,9 +228,6 @@ public function testAddNodeList()
$this->assertEquals('foo', $crawler->filterXPath('//div')->attr('class'), '->addNodeList() adds nodes from a \DOMNodeList');
}

/**
* @covers Symfony\Component\DomCrawler\Crawler::addNodes
*/
public function testAddNodes()
{
foreach ($this->createNodeList() as $node) {
Expand All @@ -278,9 +240,6 @@ public function testAddNodes()
$this->assertEquals('foo', $crawler->filterXPath('//div')->attr('class'), '->addNodes() adds nodes from an array of nodes');
}

/**
* @covers Symfony\Component\DomCrawler\Crawler::addNode
*/
public function testAddNode()
{
$crawler = new Crawler();
Expand Down Expand Up @@ -430,9 +389,6 @@ public function testFilterXpathComplexQueries()
$this->assertCount(7, $crawler->filterXPath('( ( //a | //div )//img | //ul )'));
}

/**
* @covers Symfony\Component\DomCrawler\Crawler::filterXPath
*/
public function testFilterXPath()
{
$crawler = $this->createTestCrawler();
Expand Down Expand Up @@ -595,9 +551,6 @@ public function testFilterXPathWithSelfAxes()
$this->assertCount(9, $crawler->filterXPath('self::*/a'));
}

/**
* @covers Symfony\Component\DomCrawler\Crawler::filter
*/
public function testFilter()
{
$crawler = $this->createTestCrawler();
Expand Down

0 comments on commit b33593c

Please sign in to comment.