Modernize code (Qt5 connects + init of params) #474
Conversation
Fix possible crash when accesing destroyed objects (lxqt#471)
francescmm
force-pushed
the
modernize-code
branch
from
419d2f1
to
1c9a500
Compare
francescmm
force-pushed
the
modernize-code
branch
from
1c9a500
to
7cf1d17
Compare
| ptySlaveFd = _shellProcess->pty()->slaveFd(); | ||
|
|
||
| //create emulation backend |
There was a problem hiding this comment.
Looks like this comment is gone. It's better to keep comments after refactoring.
|
|
||
| QObject::connect( widget ,SIGNAL(destroyed(QObject *)) , this , | ||
| SLOT(viewDestroyed(QObject *)) ); | ||
| //slot for close |
|
|
||
| connect(_emulation, &Emulation::imageResizeRequest, this, &Session::onEmulationSizeChange); | ||
| connect(_emulation, &Emulation::imageSizeChanged, this, &Session::onViewSizeChange); | ||
| connect(_emulation, &Emulation::cursorChanged, |
There was a problem hiding this comment.
Good catch! cursorChanged is indeed a signal of Emulation, not Vt102Emulation.
| // or KPty::login() which uses a QProcess to start /usr/bin/utempter | ||
| , _flowControl(true) | ||
| , _fullScripting(false) | ||
| , _sessionId(0) |
There was a problem hiding this comment.
Initialization for _flowControl, _flowControl, _sessionId are gone?
| , _sessionId(0) | ||
| // , _zmodemBusy(false) | ||
| // , _zmodemProc(0) | ||
| // , _zmodemProgress(0) |
There was a problem hiding this comment.
Probably better to also move initialization of zmodem-related variables to Session.h, so that we don't forget initialization in case the zmodem feature is added back.
| // , _zmodemBusy(false) | ||
| // , _zmodemProc(0) | ||
| // , _zmodemProgress(0) | ||
| , _hasDarkBackground(false) |
| @@ -491,7 +491,11 @@ public slots: | |||
| private slots: | |||
| void done(int); | |||
|
|
|||
| // void fireZModemDetected(); | |||
There was a problem hiding this comment.
Although technical functionaltiy should not be affected, it's better to avoid changing slots into ordinary functions.
| // void zmodemReadStatus(); | ||
| // void zmodemReadAndSendBlock(); | ||
| // void zmodemRcvBlock(const char *data, int len); | ||
| // void zmodemFinished(); |
We can move to that. |
In this PR I've applied two main changes:
These should be harmless modifications since they don't change any implementation.
I've postponed some real changes like using smart pointers, modern iterators, etc. until this PR goes in and clang-format is in place. I don't think it's recommendable to modify everything in one single PR.
Last thing: I've kept one old-style connect because it would make the code use qoverload. I know that this was an issue in some distros as ArchLinux and since I'm not sure QTermWidget is ship there or not, I decided to keep it.