Skip to content

Commit

Permalink
Faker safe_email -> email (#1607)
Browse files Browse the repository at this point in the history
* refactor: 💡 safe_email -> email

NOTE: Faker::Internet.safe_email is deprecated; use email instead. It
will be removed on or after 2023-10.

* test: 💍 MiniTest->Minitest
  • Loading branch information
hatsu38 authored Nov 5, 2023
1 parent d9a91bc commit 03b9f7a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,7 @@ def mock_registration_params
# test valid update param
@resource_class = User
@new_operating_thetan = 1_000_000
@email = Faker::Internet.safe_email
@email = Faker::Internet.email
@request_params = {
operating_thetan: @new_operating_thetan,
email: @email
Expand Down Expand Up @@ -612,7 +612,7 @@ def mock_registration_params
# test valid update param
@resource_class = User
@new_operating_thetan = 1_000_000
@email = Faker::Internet.safe_email
@email = Faker::Internet.email
@request_params = {
operating_thetan: @new_operating_thetan,
email: @email
Expand Down Expand Up @@ -663,7 +663,7 @@ def mock_registration_params
before do
DeviseTokenAuth.check_current_password_before_update = :password
@new_operating_thetan = 1_000_000
@email = Faker::Internet.safe_email
@email = Faker::Internet.email
end

after do
Expand Down
2 changes: 1 addition & 1 deletion test/factories/users.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
FactoryBot.define do
factory :user do
email { Faker::Internet.unique.safe_email }
email { Faker::Internet.unique.email }
password { Faker::Internet.password }
provider { 'email' }

Expand Down

0 comments on commit 03b9f7a

Please sign in to comment.