Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Python 3.12 #325

Merged
merged 9 commits into from
Jan 16, 2024
Merged

support Python 3.12 #325

merged 9 commits into from
Jan 16, 2024

Conversation

kitagry
Copy link
Member

@kitagry kitagry commented Oct 10, 2023

  • support Python3.12
  • unsupport Python3.8

and some changes.

  • flake8 error: E721 do not compare types, for exact checks use is / is not, for instance checks use isinstance()
    • I change type(hoge) == fuga to isinstance(hoge, fuga)

@hirosassa
Copy link
Collaborator

hirosassa commented Oct 10, 2023

I think we need to re-lock to update numpy to 1.26.
https://github.com/m3dev/gokart/blob/master/poetry.lock#L1224

ref: https://numpy.org/news/#numpy-1260-released

P.S.
From the numpy document displayed above, we need to deprecate Python 3.8.

@kitagry
Copy link
Member Author

kitagry commented Oct 11, 2023

Hmm. numpy 1.25 drop Python 3.8 support. https://github.com/numpy/numpy/releases/tag/v1.25.1

So, in order to we support numpy 1.26 we should drop Python 3.8.

Do you think about this? @hirosassa @Hi-king @mski-iksm @ujiuji1259

@hirosassa
Copy link
Collaborator

hirosassa commented Oct 11, 2023

I agree with dropping Python38 coz they ended active support on May 2021.

https://endoflife.date/python

@kitagry
Copy link
Member Author

kitagry commented Oct 11, 2023

Hmm, pyarrow doesn't support python3.12 yet. apache/arrow#37880

@hirosassa
Copy link
Collaborator

@kitagry hooray!! 🎉 it will be published in around 2w
apache/arrow#37880

@@ -16,7 +16,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
with:
python-version: 3.9
python-version: 3.11
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pyproject-flake8 doen't support python3.12. So, I use Python3.11 for format CI.

csachs/pyproject-flake8#30

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I Think It's OK because it's just for formatting

@kitagry
Copy link
Member Author

kitagry commented Jan 16, 2024

@Hi-king @mski-iksm @ujiuji1259 @hirosassa Please review!

And, is it ok to remove python 3.8 test CI from required and add python 3.12 test CI to required?

@Hi-king
Copy link
Member

Hi-king commented Jan 16, 2024

@kitagry THX!

@Hi-king Hi-king enabled auto-merge (squash) January 16, 2024 10:11
@Hi-king Hi-king disabled auto-merge January 16, 2024 10:12
@Hi-king Hi-king enabled auto-merge (squash) January 16, 2024 10:14
@Hi-king Hi-king merged commit 2b33286 into m3dev:master Jan 16, 2024
5 checks passed
@Hi-king
Copy link
Member

Hi-king commented Jan 16, 2024

I've changed required actions :)
image

@kitagry kitagry deleted the support-python312 branch January 16, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants