-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support Python 3.12 #325
support Python 3.12 #325
Conversation
I think we need to re-lock to update numpy to 1.26. ref: https://numpy.org/news/#numpy-1260-released P.S. |
Hmm. numpy 1.25 drop Python 3.8 support. https://github.com/numpy/numpy/releases/tag/v1.25.1 So, in order to we support numpy 1.26 we should drop Python 3.8. Do you think about this? @hirosassa @Hi-king @mski-iksm @ujiuji1259 |
I agree with dropping Python38 coz they ended active support on May 2021. |
6a235ec
to
50b5d74
Compare
Hmm, pyarrow doesn't support python3.12 yet. apache/arrow#37880 |
@kitagry hooray!! 🎉 it will be published in around 2w |
4ef81df
to
c65c97f
Compare
pyproject-flake8 doesn't support python 3.12
@@ -16,7 +16,7 @@ jobs: | |||
- uses: actions/checkout@v3 | |||
- uses: actions/setup-python@v4 | |||
with: | |||
python-version: 3.9 | |||
python-version: 3.11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pyproject-flake8 doen't support python3.12. So, I use Python3.11 for format CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I Think It's OK because it's just for formatting
@Hi-king @mski-iksm @ujiuji1259 @hirosassa Please review! And, is it ok to remove python 3.8 test CI from required and add python 3.12 test CI to required? |
@kitagry THX! |
and some changes.
is
/is not
, for instance checks useisinstance()
type(hoge) == fuga
toisinstance(hoge, fuga)