Add ini file processor #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi-king
reviewed
Oct 19, 2023
Hi-king
reviewed
Oct 19, 2023
yokomotod
reviewed
Oct 19, 2023
yokomotod
reviewed
Oct 19, 2023
test/test_target.py
Outdated
| @@ -127,6 +128,19 @@ def test_save_and_load_feather_without_store_index_in_feather(self): | |||
|
|
|||
| pd.testing.assert_frame_equal(loaded, obj) | |||
|
|
|||
| def test_save_and_load_config_ini_file(self): | |||
There was a problem hiding this comment.
@maronuu will you remove this test?
There was a problem hiding this comment.
Removed, Thank you for the comment.
|
@maronuu lgtm! |
|
I think you should the reason why you use TextFileProcessor in the PR description. |
kitagry
approved these changes
Oct 19, 2023
yokomotod
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
.inifile support forfile_processor.We use
TextFileProcessorfor.inifile.In most cases with gokart,
.inifiles are used as config files, and there are some cases that requires you to just dump.iniconfig files, likekannonlibrary development.configparserorLuigiConfigParserare seemingly suitable choices, but their functionality are sometimes overwhelming and there should be options on how to parse the loaded config files.So, in order to achieve these kind of requirements, we use
TextFileProcessorfor.iniformat. The loaded files are text, so users can choose how to parse them.