set TaskOnKart.raise_task_lock_exception_on_collision as false #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mski-iksm
requested review from
vaaaaanquish,
yokomotod,
Hi-king,
kitagry,
po3rin and
ujiuji1259
Hi-king
reviewed
Jan 10, 2024
| @@ -176,7 +173,8 @@ def make_target(self, relative_file_path: Optional[str] = None, use_unique_id: b | |||
| redis_host=self.redis_host, | |||
| redis_port=self.redis_port, | |||
| redis_timeout=self.redis_timeout, | |||
| raise_task_lock_exception_on_collision=self.raise_task_lock_exception_on_collision) | |||
| raise_task_lock_exception_on_collision=False) | |||
There was a problem hiding this comment.
@mski-iksm Plz describe why we need to keep raise_task_lock_exception_on_collision for make_redis_params while this is always set to be False
There was a problem hiding this comment.
@Hi-king
In the coming feature, TaskOnKart.run() will be wrapped with task collision lock to prevent running same task at the same time.
I want to keep RedisParams.raise_task_lock_exception_on_collision to be used in this new feature.
There was a problem hiding this comment.
@mski-iksm Thx for clarifying :)
Hi-king
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RedisParams.raise_task_lock_exception_on_collision is a option whether to fail when TaskLockException is raised (when True), or just wait until the lock is released (when False).
Originally, this setting was passed from TaskOnKart.raise_task_lock_exception_on_collision.
However, this option is not needed since task collision lock of TaskOnKart.dump() don't want to fail even when TaskLockException is raised.
Rather, we want to wait until the lock is released.
In this PR, I've changed the raise_task_lock_exception_on_collision as False for task collision lock of TaskOnKart.dump().