feat: implement DI tools for gokart #400
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Tasks sometimes uses another class like API clients in the
run
.gokart.TaskOnKart
requires to create an instance in its task, because the parameters can only be injected.Currently, we must write the following codes to do so.
Overwrite constructor
Create Instance in run
It seems to be noisy for me.
This PR aims...
Introduce a DI system inspired by FastAPI Depends.
The following is an example of this feature.
Please also check the test codes which shows the example of resolving dependencies in recursive manner.
Let me know your frank opinion for this feature.