fix: add handling for wrapped run to pickle
#401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiro-o918
changed the title
run to pickle
hiro-o918
force-pushed
the
fix/run-wrapper
branch
from
bfaec70 to
81c4e69
Compare
hiro-o918
requested review from
hirosassa,
Hi-king,
kitagry,
mski-iksm and
ujiuji1259
mski-iksm
reviewed
Oct 14, 2024
mski-iksm
reviewed
Oct 14, 2024
| task_lock.release() | ||
| logger.debug(f'Task RUN lock of {task_lock_params.redis_key} released.') | ||
| scheduler.shutdown() | ||
| return result |
There was a problem hiding this comment.
Though I cannot remember, there must be some reason that this method has return, so I think we should reconsider before removing it.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backround
As CI of a8d23f7 shows, when wrapped
runfunction cannot be pickled when the instance parameters to wraprundifferentgokart.TaskOnKartis pickled when it is passed to workers.So, the current implementation can cause pickle errors in some conditions, though the parameters of tests in a8d23f7 are tricky.
What
This PR overwrites built-in functions which are used on
pickle.dumpandpickle.load.The error mentioned above is fixed by unwrapping/wraping the
runfunction in the pickle process