feat: infer type of parameter when user doesn't specify type #403
+161
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitagry
force-pushed
the
add-default-type
branch
4 times, most recently
from
c0de16d to
6f48b39
Compare
kitagry
changed the title
kitagry
requested review from
hirosassa,
yokomotod,
Hi-king,
hiro-o918,
mski-iksm and
ujiuji1259
hiro-o918
reviewed
Oct 26, 2024
hiro-o918
reviewed
Oct 26, 2024
hiro-o918
reviewed
Oct 26, 2024
hiro-o918
reviewed
Oct 26, 2024
kitagry
force-pushed
the
add-default-type
branch
from
6f48b39 to
1cab2c6
Compare
kitagry
force-pushed
the
add-default-type
branch
from
1cab2c6 to
96d4d8e
Compare
hiro-o918
reviewed
Oct 26, 2024
| @@ -361,65 +360,115 @@ def _collect_parameter_args(self, expr: Expression) -> tuple[bool, dict[str, Exp | |||
| return True, args | |||
| return False, {} | |||
|
|
|||
| def _infer_task_on_kart_attr_init_type(self, sym: SymbolTableNode, context: Context) -> Type | None: | |||
There was a problem hiding this comment.
(just a memo for this change)
This function aims to infer type for pydantic field, which is not needed on gokart.
hirosassa
approved these changes
Oct 26, 2024
Comment on lines
+373
to
+415
| if parameter_name in ['luigi.parameter.Parameter', 'luigi.parameter.OptionalParameter']: | ||
| underlying_type = self._api.named_type('builtins.str', []) | ||
| elif parameter_name in ['luigi.parameter.IntParameter', 'luigi.parameter.OptionalIntParameter']: | ||
| underlying_type = self._api.named_type('builtins.int', []) | ||
| elif parameter_name in ['luigi.parameter.FloatParameter', 'luigi.parameter.OptionalFloatParameter']: | ||
| underlying_type = self._api.named_type('builtins.float', []) | ||
| elif parameter_name in ['luigi.parameter.BoolParameter', 'luigi.parameter.OptionalBoolParameter']: | ||
| underlying_type = self._api.named_type('builtins.bool', []) | ||
| elif parameter_name in ['luigi.parameter.DateParameter', 'luigi.parameter.MonthParameter', 'luigi.parameter.YearParameter']: | ||
| underlying_type = self._api.named_type('datetime.date', []) | ||
| elif parameter_name in ['luigi.parameter.DateHourParameter', 'luigi.parameter.DateMinuteParameter', 'luigi.parameter.DateSecondParameter']: | ||
| underlying_type = self._api.named_type('datetime.datetime', []) | ||
| elif parameter_name in ['luigi.parameter.TimeDeltaParameter']: | ||
| underlying_type = self._api.named_type('datetime.timedelta', []) | ||
| elif parameter_name in ['luigi.parameter.DictParameter', 'luigi.parameter.OptionalDictParameter']: | ||
| underlying_type = self._api.named_type('builtins.dict', [AnyType(TypeOfAny.unannotated), AnyType(TypeOfAny.unannotated)]) | ||
| elif parameter_name in ['luigi.parameter.ListParameter', 'luigi.parameter.OptionalListParameter']: | ||
| underlying_type = self._api.named_type('builtins.tuple', [AnyType(TypeOfAny.unannotated)]) | ||
| elif parameter_name in ['luigi.parameter.TupleParameter', 'luigi.parameter.OptionalTupleParameter']: | ||
| underlying_type = self._api.named_type('builtins.tuple', [AnyType(TypeOfAny.unannotated)]) | ||
| elif parameter_name in ['luigi.parameter.PathParameter', 'luigi.parameter.OptionalPathParameter']: | ||
| underlying_type = self._api.named_type('pathlib.Path', []) | ||
| elif parameter_name in ['gokart.parameter.TaskInstanceParameter']: | ||
| underlying_type = self._api.named_type('gokart.task.TaskOnKart', [AnyType(TypeOfAny.unannotated)]) | ||
| elif parameter_name in ['gokart.parameter.ListTaskInstanceParameter']: | ||
| underlying_type = self._api.named_type('builtins.list', [self._api.named_type('gokart.task.TaskOnKart', [AnyType(TypeOfAny.unannotated)])]) | ||
| elif parameter_name in ['gokart.parameter.ExplicitBoolParameter']: | ||
| underlying_type = self._api.named_type('builtins.bool', []) | ||
| elif parameter_name in ['luigi.parameter.NumericalParameter']: | ||
| underlying_type = self._get_type_from_args(parameter, 'var_type') | ||
| elif parameter_name in ['luigi.parameter.ChoiceParameter']: | ||
| underlying_type = self._get_type_from_args(parameter, 'var_type') | ||
| elif parameter_name in ['luigi.parameter.ChoiceListPareameter']: | ||
| base_type = self._get_type_from_args(parameter, 'var_type') | ||
| if base_type is not None: | ||
| underlying_type = self._api.named_type('builtins.tuple', [base_type]) | ||
| elif parameter_name in ['luigi.parameter.EnumParameter']: | ||
| underlying_type = self._get_type_from_args(parameter, 'enum') | ||
| elif parameter_name in ['luigi.parameter.EnumListParameter']: | ||
| base_type = self._get_type_from_args(parameter, 'enum') | ||
| if base_type is not None: | ||
| underlying_type = self._api.named_type('builtins.tuple', [base_type]) | ||
|
|
There was a problem hiding this comment.
memo: After Python 3.9 EOL, we can use match case syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we should write type hint for every parameters. This PR aims to infer type from Parameter names when user doesn't specify type.
Before
After