feat: Deprecate load_data_frame #417
Merged
+20
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiro-o918
reviewed
Dec 20, 2024
pyproject.toml
Outdated
| @@ -30,6 +30,7 @@ APScheduler = "*" | |||
| redis = "*" | |||
| dill = "*" | |||
| backoff = "^2.2.1" | |||
| typing-extensions = "^4.11.0" | |||
There was a problem hiding this comment.
please specify typing-extensions with python version
ref:
https://python-poetry.org/docs/dependency-specification/#multiple-constraints-dependencies
There was a problem hiding this comment.
Thank you.
Changed to use built-in warnings.deprecated with Python >= 3.13 on 8f9b3cd .
hiro-o918
reviewed
Dec 20, 2024
pyproject.toml
Outdated
| @@ -43,7 +44,6 @@ fakeredis = "*" | |||
| mypy = "*" | |||
| types-redis = "*" | |||
| matplotlib = "*" | |||
| typing-extensions = "^4.11.0" | |||
There was a problem hiding this comment.
keep this line since this package is optional on production group
kitagry
reviewed
Dec 20, 2024
poetry.lock
Outdated
| @@ -1,42 +1,41 @@ | |||
| # This file is automatically @generated by Poetry 1.8.3 and should not be changed by hand. | |||
| # This file is automatically @generated by Poetry 1.8.2 and should not be changed by hand. | |||
There was a problem hiding this comment.
fixed on ea7525b
kitagry
reviewed
Dec 20, 2024
Co-authored-by: Ryo Kitagawa <kitadrum50@gmail.com>
|
I fixed codes which is failed on CI. |
|
Thank you for the contribution!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generic function
gokart.task.TaskOnKart.loadalso supports loadingpandas.DataFrame.Optional arguments
required_columnsanddrop_columnsare not necessary because you can verify/extract columns after loadingDataFrame.