Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix contributions of non-sequential solutes, and improve performance of contributions function #43

Merged
merged 8 commits into from
Oct 22, 2024

Conversation

lmiq
Copy link
Member

@lmiq lmiq commented Oct 22, 2024

No description provided.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 86.11111% with 5 lines in your changes missing coverage. Please review.

Project coverage is 89.68%. Comparing base (6b40cf1) to head (a9ba32d).

Files with missing lines Patch % Lines
src/tools/contributions.jl 85.29% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   89.65%   89.68%   +0.02%     
==========================================
  Files          25       25              
  Lines        1615     1619       +4     
==========================================
+ Hits         1448     1452       +4     
  Misses        167      167              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lmiq lmiq merged commit 7d44441 into main Oct 22, 2024
16 of 17 checks passed
@lmiq lmiq deleted the fix_contributions branch October 22, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant