Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Mansi-mParticle committed Oct 2, 2024
1 parent 61e2ead commit 9559fca
Showing 1 changed file with 1 addition and 25 deletions.
26 changes: 1 addition & 25 deletions android-core/src/main/kotlin/com/mparticle/internal/BatchId.kt
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,10 @@ package com.mparticle.internal
import com.mparticle.internal.database.services.MessageService.ReadyMessage

class BatchId {
var mpid: Long
get() = field
val mpid: Long
var sessionId: String?
get() = field
var dataplanId: String?
get() = field
var dataplanVersion: Int?
get() = field

constructor(mpid: Long, sessionId: String?, dataplanId: String?, dataplanVersion: Int?) {
this.mpid = mpid
Expand All @@ -25,24 +21,4 @@ class BatchId {
dataplanId = readyMessage.dataplanId
dataplanVersion = readyMessage.dataplanVersion
}

override fun equals(obj: Any?): Boolean {
if (obj !is BatchId) {
return false
}
for (i in 0 until fields().size) {
if (!MPUtility.isEqual(fields()[i], obj.fields()[i])) {
return false
}
}
return true
}

override fun hashCode(): Int {
return fields().contentHashCode()
}

private fun fields(): Array<Any?> {
return arrayOf(mpid, sessionId, dataplanId, dataplanVersion)
}
}

0 comments on commit 9559fca

Please sign in to comment.