Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Identity API response caching #513

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

Mansi-mParticle
Copy link
Contributor

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Adds caching of identify and login calls and Clears that cache on modify and logout calls.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Tested with sample application. And currently Executed below Test cases:
    1)Login with same user on same session and on cold launch.
    2)Login with two different user on same session and on cold launch.
    3)Call Identity with same details as login details.
    4)Call Identity with same user details on same session and on cold launch.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copy link
Collaborator

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the commented out asserts, the added tests (SQDSDKS-6674) looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants