New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Migrate Internal user storage class to kotlin #516

Merged

Mansi-mParticle merged 2 commits into development from refactor/SQDSDKS-6721-user-storage-class

Oct 28, 2024

Contributor

Mansi-mParticle commented Oct 25, 2024

Instructions

PR target branch should be against development
PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

Migrate internal package’s Migrate UserStorage class to kotlin

Testing Plan

Was this tested locally? If not, explain why.
Tested with sample application and ran the unit test cases

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Closes https://go.mparticle.com/work/SQDSDKS-6721


          refactor: Migrate Internal user storage class to kotlin

47a6493

Mansi-mParticle requested review from einsteinx2 and rmi22186

October 25, 2024 22:01

einsteinx2 requested changes

View reviewed changes

android-core/src/main/kotlin/com/mparticle/internal/UserStorage.kt Outdated Show resolved Hide resolved

android-core/src/main/kotlin/com/mparticle/internal/UserStorage.kt Outdated Show resolved Hide resolved

android-core/src/main/kotlin/com/mparticle/internal/UserStorage.kt Outdated Show resolved Hide resolved

android-core/src/main/kotlin/com/mparticle/internal/UserStorage.kt Outdated Show resolved Hide resolved


          Address review comments

e13771b

Mansi-mParticle requested a review from einsteinx2

October 28, 2024 20:05

einsteinx2 approved these changes

View reviewed changes

Mansi-mParticle merged commit a8efd13 into development

24 checks passed

Mansi-mParticle deleted the refactor/SQDSDKS-6721-user-storage-class branch

October 28, 2024 21:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet