New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Migrate Internal CoreCallback class to kotlin #517

Merged

Mansi-mParticle merged 2 commits into development from refactor/SQDSDKS-6811-corecallback-class

Oct 30, 2024

Contributor

Mansi-mParticle commented Oct 29, 2024

Instructions

PR target branch should be against development
PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

Migrate internal package’s Migrate CoreCallback class to kotlin

Testing Plan

Was this tested locally? If not, explain why.
Tested with sample application and ran the unit test cases

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Closes https://go.mparticle.com/work/SQDSDKS-6811

Mansi-mParticle added 2 commits

October 29, 2024 18:31


          refactor: Migrate Internal CoreCallback class to kotlin

c5d868c


          fix cross platform testcases

4b84eda

Mansi-mParticle requested review from einsteinx2 and rmi22186

October 30, 2024 13:58

Mansi-mParticle force-pushed the refactor/SQDSDKS-6811-corecallback-class branch from 7cc5808 to 4b84eda Compare

October 30, 2024 20:29

einsteinx2 approved these changes

View reviewed changes

Mansi-mParticle merged commit b6ab438 into development

39 of 46 checks passed

Mansi-mParticle deleted the refactor/SQDSDKS-6811-corecallback-class branch

October 30, 2024 21:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet