New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: previous Google ad Id from being null on cold launch #518

Open

Mansi-mParticle wants to merge 1 commit into development from fix/SQDSDKS-6830-app-id-null

+23 −6

Contributor

Mansi-mParticle commented Oct 31, 2024

Instructions

PR target branch should be against development
PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

Fix a bug where the previous Google app ID is null when the app is relaunched. This happened because the app ID was stored when the app paused; now, the code has been moved to when the app is in the foreground.

Testing Plan

Was this tested locally? If not, explain why.
Tested with sample app and Executed unit test cases

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Closes https://go.mparticle.com/work/SQDSDKS-6830


          fix: previous Google ad Id from being null on cold launch

8ada158

Mansi-mParticle requested review from einsteinx2, samdozor and rmi22186

October 31, 2024 20:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet