Initial attempt to refactor persistence #847
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexs-mparticle
commented
Mar 20, 2024
src/filteredMparticleUser.js
Outdated
| @@ -67,10 +67,9 @@ export default function filteredMparticleUser( | |||
| return userAttributesLists; | |||
| }, | |||
| getAllUserAttributes: function() { | |||
| // TODO: May not need to make a copy since Store should return a copy | |||
There was a problem hiding this comment.
Note te self: we need this empty object to create a new subset of attributes for filtering.
alexs-mparticle
commented
Mar 20, 2024
src/identity.js
Outdated
| // QUESTION: can we just use mpInstance._Store.setUserAttributes here? | ||
| if (persistence && persistence[mpid]) { | ||
| persistence[mpid].ua = userAttributes; | ||
| // QUESTION: why is mpid an argument here when it's not in the signature? |
There was a problem hiding this comment.
Note to self: Defined in getCurrentUser at the top of this nested block
alexs-mparticle
force-pushed
the
refactor/add-persistence-to-store
branch
from
c3e71d0
to
d2d6b82
Compare
rmi22186
force-pushed
the
development
branch
2 times, most recently
from
0853bc2
to
dd1920f
Compare
alexs-mparticle
force-pushed
the
refactor/add-persistence-to-store
branch
2 times, most recently
from
6e7bb41
to
e2cd1b7
Compare
alexs-mparticle
force-pushed
the
refactor/add-persistence-to-store
branch
from
e2cd1b7
to
c366737
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)