Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add Type Script Support #11

Open
caisd1998 opened this issue Nov 26, 2019 · 8 comments · May be fixed by #130
Open

Feature Request: Add Type Script Support #11

caisd1998 opened this issue Nov 26, 2019 · 8 comments · May be fixed by #130

Comments

@caisd1998
Copy link

We're using type script, can you add the support?

@markgibaud-vtail
Copy link

@alexs-mparticle
Copy link
Contributor

Closing this as there is a viable solution. If this is still an issue, please reopen.

@joelain
Copy link

joelain commented Dec 16, 2021

Hey! The event types @markgibaud-vtail mentions does not solve the typescript issue for this module. We need type definitions for the items in js/index.js. Without them typescript does not know what type MParticle is when we import it.

import MParticle  from 'react-native-mparticle';

The error without the type definitions

Could not find a declaration file for module 'react-native-mparticle'. '/some/path/node_modules/react-native-mparticle/js/index.js' implicitly has an 'any' type.

@alexs-mparticle
Copy link
Contributor

@joelain Thanks for the heads up. We'll reopen this issue and see when we can get it into our backlog. Tracking internally as 77187.

@fparhat-rbi
Copy link

Please add type support +1

@BuddhaBing
Copy link

+1

@einsteinx2
Copy link

Tracking internally via https://go.mparticle.com/work/SQDSDKS-4220

@JulianKingman
Copy link

Just starting to implement MParticle, and I'm really looking forward to this, particularly with option chains like so: MParticle.User.UserAttributeType.FirstName, I've come to expect the intellisense that comes with TS.

@kunsachdeva kunsachdeva linked a pull request May 24, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants