Add types definition #130
Open
Add types definition #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
May 8, 2024
| @@ -0,0 +1,302 @@ | |||
| declare module 'react-native-mparticle'; | |||
| export default MParticle; | |||
There was a problem hiding this comment.
issue: i think you need to change to lines 1 and 2 to:
declare module 'react-native-mparticle' {
export default MParticle;
}
As currently implemented the module is declared, but is empty (tested by copying this file to our local environment). This results in the same error as before: Could not find a declaration file for module 'react-native-mparticle'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds types definition so it can be used directly in
.tsx/.tsfiles without using@ts-ignoreTesting Plan
Install in a typescript react-native or expo project
Master Issue
Closes #11